summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorTim-Philipp Müller <tim@centricular.net>2005-08-11 15:02:37 +0000
committerTim-Philipp Müller <tim@centricular.net>2005-08-11 15:02:37 +0000
commit8d2f24e71a976ca49c469e0fab28293c22e4e74d (patch)
treee53c38fa726853a469eebdbf2b2ef272d1940234
parentf7d36b17f1493f8649178aca4395e3e0d388fc66 (diff)
downloadgst-plugins-bad-8d2f24e71a976ca49c469e0fab28293c22e4e74d.tar.gz
gst-plugins-bad-8d2f24e71a976ca49c469e0fab28293c22e4e74d.tar.bz2
gst-plugins-bad-8d2f24e71a976ca49c469e0fab28293c22e4e74d.zip
ext/jpeg/gstjpegdec.*: Fix crashes/invalid memory access for pictures that have a height that is not a multiple of 16...
Original commit message from CVS: * ext/jpeg/gstjpegdec.c: (gst_jpeg_dec_init), (gst_jpeg_dec_chain), (gst_jpeg_dec_change_state): * ext/jpeg/gstjpegdec.h: Fix crashes/invalid memory access for pictures that have a height that is not a multiple of 16 (or rather: v_samp_factor * DCTSIZE). Also fix the state change function for downwards state changes (need to chain up to parent before destroying our resources, to make sure pads get deactivated and our chain function isn't running and using those very same resources in another thread). The jpeg line buffer only needs to be v_samp_factor*DCTSIZE lines per plane, not picture_height lines; allocate that on the stack.
-rw-r--r--ChangeLog16
1 files changed, 16 insertions, 0 deletions
diff --git a/ChangeLog b/ChangeLog
index 89725a1d..8bfe48f4 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,19 @@
+2005-08-11 Tim-Philipp Müller <tim at centricular dot net>
+
+ * ext/jpeg/gstjpegdec.c: (gst_jpeg_dec_init), (gst_jpeg_dec_chain),
+ (gst_jpeg_dec_change_state):
+ * ext/jpeg/gstjpegdec.h:
+ Fix crashes/invalid memory access for pictures that have a height
+ that is not a multiple of 16 (or rather: v_samp_factor * DCTSIZE).
+
+ Also fix the state change function for downwards state changes
+ (need to chain up to parent before destroying our resources, to
+ make sure pads get deactivated and our chain function isn't
+ running and using those very same resources in another thread).
+
+ The jpeg line buffer only needs to be v_samp_factor*DCTSIZE lines
+ per plane, not picture_height lines; allocate that on the stack.
+
2005-08-10 Tim-Philipp Müller <tim at centricular dot net>
* gst/wavparse/gstwavparse.c: (gst_wavparse_stream_headers),