diff options
| author | Thomas Vander Stichele <thomas@apestaart.org> | 2004-04-01 08:42:30 +0000 |
|---|---|---|
| committer | Thomas Vander Stichele <thomas@apestaart.org> | 2004-04-01 08:42:30 +0000 |
| commit | 18e678c43b5e8bac9c4ca92c09b36dc8f098df48 (patch) | |
| tree | 6d347a7decdfebd6a5f3522a3aa6f86fb024af32 /gst-libs/gst | |
| parent | 51aa0a7bdf221fda79a602946879e750d5c4d295 (diff) | |
| download | gst-plugins-bad-18e678c43b5e8bac9c4ca92c09b36dc8f098df48.tar.gz gst-plugins-bad-18e678c43b5e8bac9c4ca92c09b36dc8f098df48.tar.bz2 gst-plugins-bad-18e678c43b5e8bac9c4ca92c09b36dc8f098df48.zip | |
leak plugs and style fixes
Original commit message from CVS:
leak plugs and style fixes
Diffstat (limited to 'gst-libs/gst')
| -rw-r--r-- | gst-libs/gst/gconf/gconf.c | 9 |
1 files changed, 6 insertions, 3 deletions
diff --git a/gst-libs/gst/gconf/gconf.c b/gst-libs/gst/gconf/gconf.c index d68ffe43..00b35a22 100644 --- a/gst-libs/gst/gconf/gconf.c +++ b/gst-libs/gst/gconf/gconf.c @@ -85,7 +85,8 @@ gst_bin_find_unconnected_pad (GstBin * bin, GstPadDirection direction) * * Get GConf key @key's string value. * - * Returns: a #gchar string containing @key's value. + * Returns: a newly allocated #gchar string containing @key's value, + * or NULL in the case of an error.. */ gchar * gst_gconf_get_string (const gchar * key) @@ -99,10 +100,11 @@ gst_gconf_get_string (const gchar * key) g_free (full_key); if (error) { - g_print ("gst_gconf_get_string: error: %s\n", error->message); + g_warning ("gst_gconf_get_string: error: %s\n", error->message); g_error_free (error); + return NULL; } - /* FIXME: decide if we want to strdup this value; if we do, check for NULL */ + return value; } @@ -181,6 +183,7 @@ gst_gconf_render_bin_from_key (const gchar * key) value = gst_gconf_get_string (key); if (value) bin = gst_gconf_render_bin_from_description (value); + g_free (value); return bin; } |