diff options
| -rw-r--r-- | ChangeLog | 6 | ||||
| -rw-r--r-- | gst/filter/gstbpwsinc.c | 5 | ||||
| -rw-r--r-- | gst/filter/gstlpwsinc.c | 7 |
3 files changed, 16 insertions, 2 deletions
@@ -1,5 +1,11 @@ 2007-08-19 Sebastian Dröge <slomo@circular-chaos.org> + * gst/filter/gstbpwsinc.c: + * gst/filter/gstlpwsinc.c: + Add small comparision with the chebyshev filters in the docs. + +2007-08-19 Sebastian Dröge <slomo@circular-chaos.org> + * tests/check/elements/bpwsinc.c: (GST_START_TEST), (bpwsinc_suite): * tests/check/elements/lpwsinc.c: (GST_START_TEST), diff --git a/gst/filter/gstbpwsinc.c b/gst/filter/gstbpwsinc.c index 79fa39d9..bf399cbc 100644 --- a/gst/filter/gstbpwsinc.c +++ b/gst/filter/gstbpwsinc.c @@ -46,6 +46,11 @@ * controls rolloff and stopband attenuation. The Hamming window provides a faster rolloff but a bit * worse stopband attenuation, the other way around for the Blackman window. * </para> + * <para> + * This element has the advantage over the Chebyshev bandpass and bandreject filter that it has + * a much better rolloff when using a larger kernel size and almost linear phase. The only + * disadvantage is the much slower execution time with larger kernels. + * </para> * <title>Example launch line</title> * <para> * <programlisting> diff --git a/gst/filter/gstlpwsinc.c b/gst/filter/gstlpwsinc.c index 3cf14e5d..0db1a743 100644 --- a/gst/filter/gstlpwsinc.c +++ b/gst/filter/gstlpwsinc.c @@ -31,8 +31,6 @@ * is probably the bottleneck * - Maybe allow cascading the filter to get a better stopband attenuation. * Can be done by convolving a filter kernel with itself - * - Drop the first kernel_length/2 samples and append the same number of - * samples on EOS as the first few samples are essentialy zero. */ /** @@ -46,6 +44,11 @@ * controls rolloff and stopband attenuation. The Hamming window provides a faster rolloff but a bit * worse stopband attenuation, the other way around for the Blackman window. * </para> + * <para> + * This element has the advantage over the Chebyshev lowpass and highpass filter that it has + * a much better rolloff when using a larger kernel size and almost linear phase. The only + * disadvantage is the much slower execution time with larger kernels. + * </para> * <title>Example launch line</title> * <para> * <programlisting> |