From b23e28b2f293e8cf5d8c890ed02fe84c8f92d20f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tim-Philipp=20M=C3=BCller?= Date: Tue, 11 Dec 2007 11:54:43 +0000 Subject: gst/flv/gstflvparse.c: Don't strdup (and thus leak) codec name strings when passing them to gst_tag_list_add(). Original commit message from CVS: * gst/flv/gstflvparse.c: (gst_flv_parse_tag_audio), (gst_flv_parse_tag_video): Don't strdup (and thus leak) codec name strings when passing them to gst_tag_list_add(). --- ChangeLog | 7 +++++++ gst/flv/gstflvparse.c | 8 ++++---- 2 files changed, 11 insertions(+), 4 deletions(-) diff --git a/ChangeLog b/ChangeLog index f4787d94..28cce11c 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,10 @@ +2007-12-11 Tim-Philipp Müller + + * gst/flv/gstflvparse.c: (gst_flv_parse_tag_audio), + (gst_flv_parse_tag_video): + Don't strdup (and thus leak) codec name strings when passing + them to gst_tag_list_add(). + 2007-12-10 Wim Taymans * gst/rtpmanager/gstrtpbin.c: (gst_rtp_bin_class_init), diff --git a/gst/flv/gstflvparse.c b/gst/flv/gstflvparse.c index f7954665..a29e873b 100644 --- a/gst/flv/gstflvparse.c +++ b/gst/flv/gstflvparse.c @@ -494,7 +494,7 @@ gst_flv_parse_tag_audio (GstFLVDemux * demux, const guint8 * data, if (demux->taglist == NULL) demux->taglist = gst_tag_list_new (); gst_tag_list_add (demux->taglist, GST_TAG_MERGE_REPLACE, - GST_TAG_AUDIO_CODEC, g_strdup (codec_name), NULL); + GST_TAG_AUDIO_CODEC, codec_name, NULL); } GST_DEBUG_OBJECT (demux, "created audio pad with caps %" GST_PTR_FORMAT, @@ -577,7 +577,7 @@ gst_flv_parse_tag_audio (GstFLVDemux * demux, const guint8 * data, if (demux->taglist == NULL) demux->taglist = gst_tag_list_new (); gst_tag_list_add (demux->taglist, GST_TAG_MERGE_REPLACE, - GST_TAG_AUDIO_CODEC, g_strdup (codec_name), NULL); + GST_TAG_AUDIO_CODEC, codec_name, NULL); } gst_caps_unref (caps); @@ -767,7 +767,7 @@ gst_flv_parse_tag_video (GstFLVDemux * demux, const guint8 * data, if (demux->taglist == NULL) demux->taglist = gst_tag_list_new (); gst_tag_list_add (demux->taglist, GST_TAG_MERGE_REPLACE, - GST_TAG_VIDEO_CODEC, g_strdup (codec_name), NULL); + GST_TAG_VIDEO_CODEC, codec_name, NULL); } /* Store the caps we have set */ @@ -839,7 +839,7 @@ gst_flv_parse_tag_video (GstFLVDemux * demux, const guint8 * data, if (demux->taglist == NULL) demux->taglist = gst_tag_list_new (); gst_tag_list_add (demux->taglist, GST_TAG_MERGE_REPLACE, - GST_TAG_VIDEO_CODEC, g_strdup (codec_name), NULL); + GST_TAG_VIDEO_CODEC, codec_name, NULL); } /* Store the caps we have set */ -- cgit v1.2.1