From 71814047036e4347ada045953b58030da5829262 Mon Sep 17 00:00:00 2001 From: David Schleef Date: Tue, 1 Jan 2008 01:18:19 +0000 Subject: ext/musicbrainz/gsttrm.c: Don't emit signiture when going to READY, because it might not be ready. Original commit message from CVS: * ext/musicbrainz/gsttrm.c: Don't emit signiture when going to READY, because it might not be ready. * ext/nas/nassink.c: Remove useless call that sleeps for 5 seconds. Yup, it calls sleep(1) 5 times. Go NAS. * gst/librfb/gstrfbsrc.c: * gst/librfb/rfbdecoder.c: Initialize our debug categories properly. * gst/rawparse/gstrawparse.c: Don't register element details for a non-element. Be much more rude when subclass doesn't set a pad template (assert!). Don't unref the pad template; we don't own it. * gst/videosignal/gstvideoanalyse.c: Initialize debug category. * tests/check/Makefile.am: Ignore nassink element in tests because it has unavoidable long timeouts. --- ext/musicbrainz/gsttrm.c | 1 - ext/nas/nassink.c | 10 +++------- 2 files changed, 3 insertions(+), 8 deletions(-) (limited to 'ext') diff --git a/ext/musicbrainz/gsttrm.c b/ext/musicbrainz/gsttrm.c index 5f092b72..a4441f26 100644 --- a/ext/musicbrainz/gsttrm.c +++ b/ext/musicbrainz/gsttrm.c @@ -372,7 +372,6 @@ gst_trm_change_state (GstElement * element, GstStateChange transition) switch (transition) { case GST_STATE_CHANGE_PAUSED_TO_READY: - gst_trm_emit_signature (trm); trm_Delete (trm->trm); trm->trm = NULL; trm->data_available = FALSE; diff --git a/ext/nas/nassink.c b/ext/nas/nassink.c index a2ee0575..e2d91d18 100644 --- a/ext/nas/nassink.c +++ b/ext/nas/nassink.c @@ -171,12 +171,6 @@ gst_nas_sink_getcaps (GstBaseSink * bsink) server = nassink->audio; - if (server == NULL) { - /* FIXME: is it really a good idea to do a potentially long blocking call - * like this here? (tpm) */ - server = AuOpenServer (nassink->host, 0, NULL, 0, NULL, NULL); - } - templatecaps = gst_static_pad_template_get_caps (&sink_factory); if (server == NULL) @@ -333,8 +327,10 @@ gst_nas_sink_open (GstAudioSink * asink) /* Open Server */ sink->audio = AuOpenServer (sink->host, 0, NULL, 0, NULL, NULL); - if (sink->audio == NULL) + if (sink->audio == NULL) { + GST_DEBUG_OBJECT (sink, "opening failed"); return FALSE; + } sink->flow = AuNone; sink->need_data = 0; -- cgit v1.2.1