From ec5ed04139ae6df3420174679ca33ebe31646d22 Mon Sep 17 00:00:00 2001 From: Jan Schmidt Date: Fri, 28 Jul 2006 17:17:24 +0000 Subject: gst/audioresample/gstaudioresample.c: Don't leak references to the incoming caps. Clean them up when stopping. Original commit message from CVS: * gst/audioresample/gstaudioresample.c: (audioresample_stop), (audioresample_set_caps): Don't leak references to the incoming caps. Clean them up when stopping. * gst/videoscale/gstvideoscale.c: (gst_video_scale_class_init), (gst_video_scale_finalize): Don't leak our temporary pixel buffer. * tests/check/Makefile.am: * tests/check/pipelines/simple-launch-lines.c: (run_pipeline), (GST_START_TEST), (simple_launch_lines_suite): Fix leaks and re-enable the test for valgrind checking. --- gst/audioresample/gstaudioresample.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'gst/audioresample/gstaudioresample.c') diff --git a/gst/audioresample/gstaudioresample.c b/gst/audioresample/gstaudioresample.c index 687a0637..c878d02e 100644 --- a/gst/audioresample/gstaudioresample.c +++ b/gst/audioresample/gstaudioresample.c @@ -223,6 +223,9 @@ audioresample_stop (GstBaseTransform * base) audioresample->resample = NULL; } + gst_caps_replace (&audioresample->sinkcaps, NULL); + gst_caps_replace (&audioresample->srccaps, NULL); + return TRUE; } @@ -438,10 +441,7 @@ audioresample_set_caps (GstBaseTransform * base, GstCaps * incaps, /* save caps so we can short-circuit in the size_transform if the caps * are the same */ - /* FIXME: clean them up in state change ? */ - gst_caps_ref (incaps); gst_caps_replace (&audioresample->sinkcaps, incaps); - gst_caps_ref (outcaps); gst_caps_replace (&audioresample->srccaps, outcaps); return TRUE; -- cgit v1.2.1