diff options
author | David Robillard <d@drobilla.net> | 2016-12-13 17:51:55 -0500 |
---|---|---|
committer | David Robillard <d@drobilla.net> | 2016-12-13 19:15:29 -0500 |
commit | ad43d2e08cea225635b56c5473a768bc853ecda3 (patch) | |
tree | 472a8c6dc605ba63903206a14549e8340efcf137 /src/server/DuplexPort.hpp | |
parent | 0752556bde5659a933744658cdf63509000a5080 (diff) | |
download | ingen-ad43d2e08cea225635b56c5473a768bc853ecda3.tar.gz ingen-ad43d2e08cea225635b56c5473a768bc853ecda3.tar.bz2 ingen-ad43d2e08cea225635b56c5473a768bc853ecda3.zip |
Remove virtual inheritance from Port hierarchy
This was confusing stoat, and is questionable design anyway. The OutputPort
functionality has been moved to PortImpl, which is a basic port with buffers
suitable for use as an output, and is overridden by InputPort and DuplexPort
where necessary.
Diffstat (limited to 'src/server/DuplexPort.hpp')
-rw-r--r-- | src/server/DuplexPort.hpp | 12 |
1 files changed, 2 insertions, 10 deletions
diff --git a/src/server/DuplexPort.hpp b/src/server/DuplexPort.hpp index 836faa36..adf32a88 100644 --- a/src/server/DuplexPort.hpp +++ b/src/server/DuplexPort.hpp @@ -1,6 +1,6 @@ /* This file is part of Ingen. - Copyright 2007-2015 David Robillard <http://drobilla.net/> + Copyright 2007-2016 David Robillard <http://drobilla.net/> Ingen is free software: you can redistribute it and/or modify it under the terms of the GNU Affero General Public License as published by the Free @@ -21,14 +21,13 @@ #include "BufferRef.hpp" #include "InputPort.hpp" -#include "OutputPort.hpp" namespace Ingen { namespace Server { class BlockImpl; -/** A duplex Port (both an InputPort and an OutputPort on a Graph) +/** A duplex Port (both an input and output port on a Graph) * * This is used for Graph ports, since they need to appear as both an input and * an output port based on context. There are no actual duplex ports in Ingen, @@ -38,7 +37,6 @@ class BlockImpl; * \ingroup engine */ class DuplexPort : public InputPort - , public OutputPort , public boost::intrusive::slist_base_hook<> // In GraphImpl { public: @@ -91,12 +89,6 @@ public: SampleCount next_value_offset(SampleCount offset, SampleCount end) const; void update_values(SampleCount offset, uint32_t voice); - - bool is_input() const { return !_is_output; } - bool is_output() const { return _is_output; } - -protected: - bool _is_output; }; } // namespace Server |