summaryrefslogtreecommitdiffstats
path: root/src
AgeCommit message (Collapse)AuthorFilesLines
10 daysFix spellingHEADmainDavid Robillard6-7/+7
12 daysSuppress new warnings in clang-tidyDavid Robillard1-0/+1
12 daysAvoid potentially returning a reference to a localDavid Robillard1-10/+6
This case shouldn't happen anyway since it's handled at the caller, which is best not only because of this issue, but because having set_property() maybe not set the property is confusing.
12 daysUse std::min() and std::max()David Robillard4-16/+7
12 daysPut local utility function in anonymous namespaceDavid Robillard1-0/+4
12 daysFully parenthesize expressionsDavid Robillard9-16/+16
12 daysClean up includes and forward declarationsDavid Robillard62-158/+38
12 daysAvoid using fallback for dependencies without a subprojectDavid Robillard1-1/+0
This screws things up with older meson versions, particularly with include_type 'system'. I don't think it had any purpose since there's no corresponding subproject inside this one anyway.
2025-01-20Use "system" include type for all dependenciesDavid Robillard2-0/+2
Things get confused when these flags differ across projects, so universally use "system" for external dependencies.
2024-12-19Order dependencies to prioritize flags of lower level librariesDavid Robillard1-2/+4
Specifically, to make the "system" include type for LV2 work and suppress C warnings there. Otherwise, the settings from other projects that depend on it (like lilv) take priority. This seems broken to me, and didn't used to happen, so I'm not really sure what's changed, but this fixes it.
2024-12-02Fix potential use of uninitialized valueDavid Robillard1-1/+1
According to GCC's -Wmaybe-uninitialized, this is a potential use of an uninitialized value. I'm not seeing it, but the pattern with get_property() everywhere else is to store the return value as a reference, which makes the warning go away, so do that.
2024-11-24Remove IWYU pragmas that no longer seem necessaryDavid Robillard19-34/+20
In a few cases here, we could get away with just a forward declaration but IWYU can't figure it out. Since this isn't a huge deal, just do what the tool says, since it's overall less hassle to just do what it says.
2024-11-24Use angle brackets for library includesDavid Robillard189-1263/+1392
2024-10-26Fix line wrapping in commentsDavid Robillard5-8/+14
2024-10-12Fix configuration directory creation error handlingDavid Robillard1-2/+4
2024-10-11Add missing includeDavid Robillard1-0/+1
Apparently things are defined in different headers in different JACK headers.
2024-10-11Use std::transform()David Robillard2-18/+29
2024-10-11Use std::find_if()David Robillard4-51/+58
2024-10-11Use std::count_if()David Robillard2-16/+10
2024-10-11Use std::any_of()David Robillard8-65/+54
2024-10-11Clarify atom forge buffer dereferencing codeDavid Robillard1-2/+3
2024-10-11Handle realloc failure and avoid potential null pointer arithmeticDavid Robillard4-8/+29
2024-10-11Move AtomForge implementation out of public headersDavid Robillard2-0/+117
2024-10-11Pass strings and large structures by const referenceDavid Robillard2-5/+5
2024-10-11Call std::terminate() directly instead of rethrowing nothingDavid Robillard1-0/+13
2024-10-11Remove redundant method overrideDavid Robillard1-7/+0
2024-10-11Add missing const qualifiersDavid Robillard6-20/+20
2024-10-11Fix confusing iteration over collections of pointersDavid Robillard2-5/+5
2024-10-11Reduce variable scopesDavid Robillard4-15/+15
2024-10-11Make more single-argument constructors explicitDavid Robillard9-12/+19
2024-10-11Simplify PortTypeDavid Robillard16-105/+99
2024-10-06Fix inconsistent C-style castDavid Robillard1-1/+1
2024-10-06Avoid using uninitialized va_list variablesDavid Robillard1-14/+20
2024-10-06Explicitly destroy the world in LV2 pluginDavid Robillard1-0/+1
Makes no real difference, but avoids a seemingly unused variable.
2024-10-06Explicitly disallow copying or moving of AppDavid Robillard1-0/+5
2024-10-06Avoid inefficient use of substr() to set strings to a prefixDavid Robillard6-7/+7
2024-10-06Remove dead codeDavid Robillard2-15/+0
2024-10-06Remove redundant conditional clauseDavid Robillard1-1/+1
2024-10-06Remove redundant assignmentDavid Robillard1-1/+0
2024-07-17Add missing namespace commentDavid Robillard1-1/+1
2024-07-17Avoid use of jack_frame_time()David Robillard2-22/+33
This seems to be broken on the pipewire implementation of Jack, but we use FrameTimer for this on other drivers anyway, so just use that for Jack as well and avoid the issue entirely. Conveniently also exercises the clock and timestamp DLL code, which as it turns out, was itself broken.
2024-07-17Use uppercase integer literal suffixesDavid Robillard5-8/+6
2024-07-17Clean up includes and forward declarationsDavid Robillard34-25/+18
According to include-what-you-use 0.22 on LLVM 18, anyway. Most of the changes seem vaguely reasonable, so as usual, just go with what the tool says because it's most useful when reports are typically clean.
2024-07-17Remove redundant inline specifierDavid Robillard2-2/+1
2024-07-17Avoid C-style casts and some size type conversionsDavid Robillard23-49/+55
Aside from the syntactic cast changes, reduces some size types to 32-bits, since they can never be so large in practice. This eliminates some type conversions and shaves a few bytes.
2024-07-17Remove redundant castsDavid Robillard14-22/+17
2024-07-17Use empty() method instead of checking lengthDavid Robillard4-5/+3
2024-07-17Avoid return with void valueDavid Robillard3-3/+2
2024-07-17Remove unused local variableDavid Robillard2-2/+0
2024-07-17Suppress new warnings in clang and clang-tidy 18David Robillard3-0/+8