From e98e0618a8d6f70d8467284c0700ed614d537afa Mon Sep 17 00:00:00 2001 From: David Robillard Date: Mon, 14 Dec 2020 21:15:56 +0100 Subject: Isolate and initialize variable declarations --- .clang-tidy | 2 -- src/gui/MessagesWindow.cpp | 3 ++- src/gui/WindowFactory.cpp | 3 ++- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.clang-tidy b/.clang-tidy index c27770ae..9c725bea 100644 --- a/.clang-tidy +++ b/.clang-tidy @@ -31,7 +31,6 @@ Checks: > -clang-analyzer-valist.Uninitialized, -clang-analyzer-webkit.NoUncountedMemberChecker, -cppcoreguidelines-avoid-non-const-global-variables, - -cppcoreguidelines-init-variables, -cppcoreguidelines-macro-usage, -cppcoreguidelines-no-malloc, -cppcoreguidelines-owning-memory, @@ -69,7 +68,6 @@ Checks: > -readability-delete-null-pointer, -readability-implicit-bool-conversion, -readability-inconsistent-declaration-parameter-name, - -readability-isolate-declaration, -readability-redundant-smartptr-get, -readability-use-anyofallof, WarningsAsErrors: '*' diff --git a/src/gui/MessagesWindow.cpp b/src/gui/MessagesWindow.cpp index d8003a33..0f0dcce5 100644 --- a/src/gui/MessagesWindow.cpp +++ b/src/gui/MessagesWindow.cpp @@ -107,8 +107,9 @@ void MessagesWindow::flush() { while (true) { - LV2_URID type; + LV2_URID type = 0; std::string line; + { std::lock_guard lock(_mutex); if (!_stream.rdbuf()->in_avail()) { diff --git a/src/gui/WindowFactory.cpp b/src/gui/WindowFactory.cpp index 9a21cce3..a394f3f5 100644 --- a/src/gui/WindowFactory.cpp +++ b/src/gui/WindowFactory.cpp @@ -222,7 +222,8 @@ WindowFactory::present_load_plugin(std::shared_ptr graph, _load_plugin_win->set_modal(false); _load_plugin_win->set_type_hint(Gdk::WINDOW_TYPE_HINT_DIALOG); if (w->second) { - int width, height; + int width = 0; + int height = 0; w->second->get_size(width, height); _load_plugin_win->set_default_size(width - width / 8, height / 2); } -- cgit v1.2.1