From e2d1344c7c4960da1f57e656c87c4599d81988aa Mon Sep 17 00:00:00 2001 From: David Robillard Date: Mon, 25 Dec 2017 12:34:07 -0500 Subject: Remove trivial destructors and use default where possible --- src/server/Driver.hpp | 2 +- src/server/Event.hpp | 2 -- src/server/NodeImpl.hpp | 2 -- src/server/PluginImpl.hpp | 2 -- src/server/PortImpl.cpp | 4 ---- src/server/PortImpl.hpp | 2 -- src/server/events/CreateBlock.cpp | 4 ---- src/server/events/CreateBlock.hpp | 2 -- src/server/events/Mark.cpp | 4 ---- src/server/events/Mark.hpp | 2 -- src/server/events/Move.cpp | 4 ---- src/server/events/Move.hpp | 2 -- src/server/events/SetPortValue.cpp | 4 ---- src/server/events/SetPortValue.hpp | 2 -- src/server/internals/Note.cpp | 4 ---- src/server/internals/Note.hpp | 2 -- 16 files changed, 1 insertion(+), 43 deletions(-) (limited to 'src/server') diff --git a/src/server/Driver.hpp b/src/server/Driver.hpp index eae90084..3014429e 100644 --- a/src/server/Driver.hpp +++ b/src/server/Driver.hpp @@ -39,7 +39,7 @@ class EnginePort; */ class Driver : public Raul::Noncopyable { public: - virtual ~Driver() {} + virtual ~Driver() = default; /** Activate driver (begin processing graph and events). */ virtual bool activate() { return true; } diff --git a/src/server/Event.hpp b/src/server/Event.hpp index 6c414fed..2cd17aa2 100644 --- a/src/server/Event.hpp +++ b/src/server/Event.hpp @@ -52,8 +52,6 @@ class PreProcessContext; class Event : public Raul::Deletable, public Raul::Noncopyable { public: - virtual ~Event() {} - /** Event mode to distinguish normal events from undo events. */ enum class Mode { NORMAL, UNDO, REDO }; diff --git a/src/server/NodeImpl.hpp b/src/server/NodeImpl.hpp index b5b1508b..81abb3ef 100644 --- a/src/server/NodeImpl.hpp +++ b/src/server/NodeImpl.hpp @@ -49,8 +49,6 @@ class RunContext; class NodeImpl : public Node { public: - virtual ~NodeImpl() {} - const Raul::Symbol& symbol() const { return _symbol; } Node* graph_parent() const { return _parent; } diff --git a/src/server/PluginImpl.hpp b/src/server/PluginImpl.hpp index 07798e45..869c6520 100644 --- a/src/server/PluginImpl.hpp +++ b/src/server/PluginImpl.hpp @@ -50,8 +50,6 @@ public: , _is_zombie(false) {} - virtual ~PluginImpl() {} - virtual BlockImpl* instantiate(BufferFactory& bufs, const Raul::Symbol& symbol, bool polyphonic, diff --git a/src/server/PortImpl.cpp b/src/server/PortImpl.cpp index 3302ff95..50a48fbd 100644 --- a/src/server/PortImpl.cpp +++ b/src/server/PortImpl.cpp @@ -104,10 +104,6 @@ PortImpl::PortImpl(BufferFactory& bufs, get_buffers(bufs, &BufferFactory::get_buffer, _voices, poly, 0); } -PortImpl::~PortImpl() -{ -} - bool PortImpl::get_buffers(BufferFactory& bufs, GetFn get, diff --git a/src/server/PortImpl.hpp b/src/server/PortImpl.hpp index 6f04a552..b3b757ff 100644 --- a/src/server/PortImpl.hpp +++ b/src/server/PortImpl.hpp @@ -97,8 +97,6 @@ public: size_t buffer_size = 0, bool is_output = true); - ~PortImpl(); - virtual GraphType graph_type() const { return GraphType::PORT; } /** A port's parent is always a block, so static cast should be safe */ diff --git a/src/server/events/CreateBlock.cpp b/src/server/events/CreateBlock.cpp index af2134e1..c636bf3c 100644 --- a/src/server/events/CreateBlock.cpp +++ b/src/server/events/CreateBlock.cpp @@ -48,10 +48,6 @@ CreateBlock::CreateBlock(Engine& engine, , _block(NULL) {} -CreateBlock::~CreateBlock() -{ -} - bool CreateBlock::pre_process(PreProcessContext& ctx) { diff --git a/src/server/events/CreateBlock.hpp b/src/server/events/CreateBlock.hpp index bba25534..a9ff39ee 100644 --- a/src/server/events/CreateBlock.hpp +++ b/src/server/events/CreateBlock.hpp @@ -45,8 +45,6 @@ public: const Raul::Path& block_path, Properties& properties); - ~CreateBlock(); - bool pre_process(PreProcessContext& ctx); void execute(RunContext& context); void post_process(); diff --git a/src/server/events/Mark.cpp b/src/server/events/Mark.cpp index 93ab3071..eb956f17 100644 --- a/src/server/events/Mark.cpp +++ b/src/server/events/Mark.cpp @@ -41,10 +41,6 @@ Mark::Mark(Engine& engine, , _depth(0) {} -Mark::~Mark() -{ -} - bool Mark::pre_process(PreProcessContext& ctx) { diff --git a/src/server/events/Mark.hpp b/src/server/events/Mark.hpp index b037b56d..eaeb9332 100644 --- a/src/server/events/Mark.hpp +++ b/src/server/events/Mark.hpp @@ -46,8 +46,6 @@ public: SampleCount timestamp, const Ingen::BundleEnd& msg); - ~Mark(); - bool pre_process(PreProcessContext& ctx); void execute(RunContext& context); void post_process(); diff --git a/src/server/events/Move.cpp b/src/server/events/Move.cpp index 681c99da..b0935675 100644 --- a/src/server/events/Move.cpp +++ b/src/server/events/Move.cpp @@ -38,10 +38,6 @@ Move::Move(Engine& engine, { } -Move::~Move() -{ -} - bool Move::pre_process(PreProcessContext& ctx) { diff --git a/src/server/events/Move.hpp b/src/server/events/Move.hpp index 4e17033a..459d2709 100644 --- a/src/server/events/Move.hpp +++ b/src/server/events/Move.hpp @@ -41,8 +41,6 @@ public: SampleCount timestamp, const Ingen::Move& msg); - ~Move(); - bool pre_process(PreProcessContext& ctx); void execute(RunContext& context); void post_process(); diff --git a/src/server/events/SetPortValue.cpp b/src/server/events/SetPortValue.cpp index 89c92580..62f2def6 100644 --- a/src/server/events/SetPortValue.cpp +++ b/src/server/events/SetPortValue.cpp @@ -49,10 +49,6 @@ SetPortValue::SetPortValue(Engine& engine, { } -SetPortValue::~SetPortValue() -{ -} - bool SetPortValue::pre_process(PreProcessContext& ctx) { diff --git a/src/server/events/SetPortValue.hpp b/src/server/events/SetPortValue.hpp index 07f1bbac..4df60019 100644 --- a/src/server/events/SetPortValue.hpp +++ b/src/server/events/SetPortValue.hpp @@ -47,8 +47,6 @@ public: bool activity, bool synthetic = false); - ~SetPortValue(); - bool pre_process(PreProcessContext& ctx); void execute(RunContext& context); void post_process(); diff --git a/src/server/internals/Note.cpp b/src/server/internals/Note.cpp index 021967e9..754d76f2 100644 --- a/src/server/internals/Note.cpp +++ b/src/server/internals/Note.cpp @@ -127,10 +127,6 @@ NoteNode::NoteNode(InternalPlugin* plugin, _ports->at(7) = _pressure_port; } -NoteNode::~NoteNode() -{ -} - bool NoteNode::prepare_poly(BufferFactory& bufs, uint32_t poly) { diff --git a/src/server/internals/Note.hpp b/src/server/internals/Note.hpp index e8593768..1e60c130 100644 --- a/src/server/internals/Note.hpp +++ b/src/server/internals/Note.hpp @@ -45,8 +45,6 @@ public: GraphImpl* parent, SampleRate srate); - ~NoteNode(); - bool prepare_poly(BufferFactory& bufs, uint32_t poly); bool apply_poly(RunContext& context, uint32_t poly); -- cgit v1.2.1