From 14e30ac0256161439dd2bd7a80c3eba40abebad2 Mon Sep 17 00:00:00 2001 From: David Robillard Date: Thu, 30 Sep 2010 08:23:42 +0000 Subject: Declare single-argument constructors explicit (except where implicit conversion is actually desired). See http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Explicit_Constructors git-svn-id: http://svn.drobilla.net/lad/trunk/ingen@2619 a436a847-0d15-0410-975c-d299462d15a1 --- src/engine/AudioBuffer.cpp | 2 +- src/engine/ControlBindings.hpp | 2 +- src/engine/Driver.hpp | 2 +- src/engine/Engine.hpp | 2 +- src/engine/EventSource.hpp | 2 +- src/engine/HTTPClientSender.hpp | 2 +- src/engine/HTTPEngineReceiver.hpp | 2 +- src/engine/JackDriver.hpp | 2 +- src/engine/LV2Info.hpp | 2 +- src/engine/MessageContext.hpp | 2 +- src/engine/NodeFactory.hpp | 2 +- src/engine/OSCClientSender.hpp | 2 +- src/engine/OSCEngineReceiver.hpp | 2 +- src/engine/ProcessContext.hpp | 2 +- src/engine/QueuedEvent.hpp | 2 +- src/shared/LV2Features.hpp | 2 +- 16 files changed, 16 insertions(+), 16 deletions(-) (limited to 'src') diff --git a/src/engine/AudioBuffer.cpp b/src/engine/AudioBuffer.cpp index d41309d3..65b8040e 100644 --- a/src/engine/AudioBuffer.cpp +++ b/src/engine/AudioBuffer.cpp @@ -15,8 +15,8 @@ * 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA */ -#include #include +#include #include "raul/log.hpp" #include "raul/SharedPtr.hpp" #include "atom.lv2/atom.h" diff --git a/src/engine/ControlBindings.hpp b/src/engine/ControlBindings.hpp index 60f582e9..89c9367a 100644 --- a/src/engine/ControlBindings.hpp +++ b/src/engine/ControlBindings.hpp @@ -56,7 +56,7 @@ public: typedef std::map Bindings; - ControlBindings(Engine& engine); + explicit ControlBindings(Engine& engine); ~ControlBindings(); void learn(PortImpl* port); diff --git a/src/engine/Driver.hpp b/src/engine/Driver.hpp index 7ba29831..f87ec338 100644 --- a/src/engine/Driver.hpp +++ b/src/engine/Driver.hpp @@ -58,7 +58,7 @@ public: DuplexPort* patch_port() const { return _patch_port; } protected: - DriverPort(DuplexPort* port) : _patch_port(port) {} + explicit DriverPort(DuplexPort* port) : _patch_port(port) {} DuplexPort* _patch_port; }; diff --git a/src/engine/Engine.hpp b/src/engine/Engine.hpp index 577ac461..9f0f08a8 100644 --- a/src/engine/Engine.hpp +++ b/src/engine/Engine.hpp @@ -64,7 +64,7 @@ class QueuedEvent; class Engine : public boost::noncopyable { public: - Engine(Ingen::Shared::World* world); + explicit Engine(Ingen::Shared::World* world); virtual ~Engine(); diff --git a/src/engine/EventSource.hpp b/src/engine/EventSource.hpp index dab8d90f..05f7ef0c 100644 --- a/src/engine/EventSource.hpp +++ b/src/engine/EventSource.hpp @@ -39,7 +39,7 @@ class ProcessContext; class EventSource : protected Raul::Slave { public: - EventSource(size_t queue_size); + explicit EventSource(size_t queue_size); virtual ~EventSource(); virtual void activate_source() { Slave::start(); } diff --git a/src/engine/HTTPClientSender.hpp b/src/engine/HTTPClientSender.hpp index f6144624..37b9b112 100644 --- a/src/engine/HTTPClientSender.hpp +++ b/src/engine/HTTPClientSender.hpp @@ -43,7 +43,7 @@ class HTTPClientSender , public Shared::HTTPSender { public: - HTTPClientSender(Engine& engine) + explicit HTTPClientSender(Engine& engine) : _engine(engine) , _enabled(true) {} diff --git a/src/engine/HTTPEngineReceiver.hpp b/src/engine/HTTPEngineReceiver.hpp index 37578b00..a8529569 100644 --- a/src/engine/HTTPEngineReceiver.hpp +++ b/src/engine/HTTPEngineReceiver.hpp @@ -36,7 +36,7 @@ public: private: struct ReceiveThread : public Raul::Thread { - ReceiveThread(HTTPEngineReceiver& receiver) : _receiver(receiver) {} + explicit ReceiveThread(HTTPEngineReceiver& receiver) : _receiver(receiver) {} virtual void _run(); virtual void whip() { while (_receiver.unprepared_events()) diff --git a/src/engine/JackDriver.hpp b/src/engine/JackDriver.hpp index 24477692..b3184f59 100644 --- a/src/engine/JackDriver.hpp +++ b/src/engine/JackDriver.hpp @@ -77,7 +77,7 @@ private: class JackDriver : public Driver { public: - JackDriver(Engine& engine); + explicit JackDriver(Engine& engine); ~JackDriver(); bool supports(Shared::PortType port_type, Shared::EventType event_type); diff --git a/src/engine/LV2Info.hpp b/src/engine/LV2Info.hpp index a0e20988..386eb057 100644 --- a/src/engine/LV2Info.hpp +++ b/src/engine/LV2Info.hpp @@ -36,7 +36,7 @@ namespace Shared { class Node; } */ class LV2Info { public: - LV2Info(Ingen::Shared::World* world); + explicit LV2Info(Ingen::Shared::World* world); ~LV2Info(); SLV2Value input_class; diff --git a/src/engine/MessageContext.hpp b/src/engine/MessageContext.hpp index 866cebed..8b7074ea 100644 --- a/src/engine/MessageContext.hpp +++ b/src/engine/MessageContext.hpp @@ -45,7 +45,7 @@ class PortImpl; class MessageContext : public Context, public Raul::Thread { public: - MessageContext(Engine& engine) + explicit MessageContext(Engine& engine) : Context(engine, MESSAGE) , Raul::Thread("MessageContext") , _sem(0) diff --git a/src/engine/NodeFactory.hpp b/src/engine/NodeFactory.hpp index 45505248..88a4b099 100644 --- a/src/engine/NodeFactory.hpp +++ b/src/engine/NodeFactory.hpp @@ -51,7 +51,7 @@ class LV2Info; class NodeFactory { public: - NodeFactory(Ingen::Shared::World* world); + explicit NodeFactory(Ingen::Shared::World* world); ~NodeFactory(); void load_plugins(); diff --git a/src/engine/OSCClientSender.hpp b/src/engine/OSCClientSender.hpp index 3dc57fc5..09d2e452 100644 --- a/src/engine/OSCClientSender.hpp +++ b/src/engine/OSCClientSender.hpp @@ -38,7 +38,7 @@ namespace Shared { class EngineInterface; } class OSCClientSender : public Shared::ClientInterface, public Shared::OSCSender { public: - OSCClientSender(const Raul::URI& url) + explicit OSCClientSender(const Raul::URI& url) : _url(url) { _address = lo_address_new_from_url(url.c_str()); diff --git a/src/engine/OSCEngineReceiver.hpp b/src/engine/OSCEngineReceiver.hpp index a2a80190..02fdfe00 100644 --- a/src/engine/OSCEngineReceiver.hpp +++ b/src/engine/OSCEngineReceiver.hpp @@ -67,7 +67,7 @@ public: private: struct ReceiveThread : public Raul::Thread { - ReceiveThread(OSCEngineReceiver& receiver) : _receiver(receiver) {} + explicit ReceiveThread(OSCEngineReceiver& receiver) : _receiver(receiver) {} virtual void _run(); private: OSCEngineReceiver& _receiver; diff --git a/src/engine/ProcessContext.hpp b/src/engine/ProcessContext.hpp index 74a3a4fc..e7e8a001 100644 --- a/src/engine/ProcessContext.hpp +++ b/src/engine/ProcessContext.hpp @@ -37,7 +37,7 @@ namespace Ingen { class ProcessContext : public Context { public: - ProcessContext(Engine& engine) : Context(engine, AUDIO) {} + explicit ProcessContext(Engine& engine) : Context(engine, AUDIO) {} }; diff --git a/src/engine/QueuedEvent.hpp b/src/engine/QueuedEvent.hpp index 26c3e7a5..3fe75ffb 100644 --- a/src/engine/QueuedEvent.hpp +++ b/src/engine/QueuedEvent.hpp @@ -61,7 +61,7 @@ protected: {} // NULL event base (for internal events only!) - QueuedEvent(Engine& engine) + explicit QueuedEvent(Engine& engine) : Event(engine, SharedPtr(), 0) , _pre_processed(false) , _blocking(false) diff --git a/src/shared/LV2Features.hpp b/src/shared/LV2Features.hpp index cf771adc..1582adb5 100644 --- a/src/shared/LV2Features.hpp +++ b/src/shared/LV2Features.hpp @@ -46,7 +46,7 @@ public: public: typedef std::vector< SharedPtr > FeatureVector; - FeatureArray(FeatureVector& features) + explicit FeatureArray(FeatureVector& features) : _features(features) { _array = (LV2_Feature**)malloc(sizeof(LV2_Feature) * (features.size() + 1)); -- cgit v1.2.1