From 63f013dd2492f6c01792198aceb6874ccf227086 Mon Sep 17 00:00:00 2001 From: David Robillard Date: Fri, 15 Nov 2024 18:45:41 -0500 Subject: Remove transport position dumping from Jack process callback This is handy at times, but prints in the process callback which is obviously not realtime safe. The communication dumping is, though, and both are controlled by the same option, so there wasn't a way to enable that without introducing a pretty severe performance issue in the audio thread. So, simply remove it for now. If transport dumping is really needed, it can be implemented by sending the information to the main thread for printing there, which will be easier after the upcoming work to improve the communication facilities. --- NEWS | 3 ++- src/jack.c | 2 -- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/NEWS b/NEWS index fb9e227..19209ad 100644 --- a/NEWS +++ b/NEWS @@ -11,13 +11,14 @@ jalv (1.6.9) unstable; urgency=medium * Fix minor memory leaks * Reduce Jack process callback overhead * Remove Gtk2 interface + * Remove transport position dumping from Jack process callback * Replace use of deprecated Gtk interfaces * Switch to external zix dependency * Use Gtk switches instead of checkboxes for toggle controls * Use fewer platform-specific APIs * Use portable zix filesystem API - -- David Robillard Fri, 15 Nov 2024 23:44:39 +0000 + -- David Robillard Fri, 15 Nov 2024 23:44:55 +0000 jalv (1.6.8) stable; urgency=medium diff --git a/src/jack.c b/src/jack.c index 7971987..3a92ff4 100644 --- a/src/jack.c +++ b/src/jack.c @@ -121,8 +121,6 @@ jack_process_cb(jack_nframes_t nframes, void* data) lv2_atom_forge_key(forge, jalv->urids.time_beatsPerMinute); lv2_atom_forge_float(forge, pos.beats_per_minute); } - - jalv_dump_atom(jalv, stdout, "Position", lv2_pos, 32); } // Update transport state to expected values for next cycle -- cgit v1.2.1