From b5ff339e2c3dfc8ad4d73c21b6887a58a6c71c9d Mon Sep 17 00:00:00 2001 From: David Robillard Date: Sat, 8 Jun 2013 18:13:38 +0000 Subject: Fix potential ringbuffer race for UI events. git-svn-id: http://svn.drobilla.net/lad/trunk/jalv@5124 a436a847-0d15-0410-975c-d299462d15a1 --- src/jalv.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'src/jalv.c') diff --git a/src/jalv.c b/src/jalv.c index 946f98e..f174eb1 100644 --- a/src/jalv.c +++ b/src/jalv.c @@ -746,7 +746,9 @@ jalv_emit_ui_events(Jalv* jalv) { ControlChange ev; const size_t space = jack_ringbuffer_read_space(jalv->plugin_events); - for (size_t i = 0; i < space; i += sizeof(ev) + ev.size) { + for (size_t i = 0; + i + sizeof(ev) + sizeof(float) <= space; + i += sizeof(ev) + ev.size) { // Read event header to get the size jack_ringbuffer_read(jalv->plugin_events, (char*)&ev, sizeof(ev)); -- cgit v1.2.1