diff options
| author | David Robillard <d@drobilla.net> | 2020-11-27 17:57:57 +0100 |
|---|---|---|
| committer | David Robillard <d@drobilla.net> | 2020-11-27 21:42:51 +0100 |
| commit | b04fa862a1daeabd0a60a479cb5e3cacac4c94b2 (patch) | |
| tree | 39544d105c5a0087aef8984599680be094480d91 /src/Patchage.cpp | |
| parent | 1be7c1b92c06880cf21f79cfa5419240f14e4fa4 (diff) | |
| download | patchage-b04fa862a1daeabd0a60a479cb5e3cacac4c94b2.tar.gz patchage-b04fa862a1daeabd0a60a479cb5e3cacac4c94b2.tar.bz2 patchage-b04fa862a1daeabd0a60a479cb5e3cacac4c94b2.zip | |
Don't use else after return
I don't always agree with this one, but in this case it's reasonable enough.
Diffstat (limited to 'src/Patchage.cpp')
| -rw-r--r-- | src/Patchage.cpp | 13 |
1 files changed, 9 insertions, 4 deletions
diff --git a/src/Patchage.cpp b/src/Patchage.cpp index 678967a..d4b4a36 100644 --- a/src/Patchage.cpp +++ b/src/Patchage.cpp @@ -92,11 +92,16 @@ port_order(const GanvPort* a, const GanvPort* b, void* data) if (pa && pb) { if (pa->order() && pb->order()) { return *pa->order() - *pb->order(); - } else if (pa->order()) { + } + + if (pa->order()) { return -1; - } else if (pb->order()) { + } + + if (pb->order()) { return 1; } + return pa->name().compare(pb->name()); } return 0; @@ -489,10 +494,10 @@ Patchage::update_toolbar() static bool updating = false; if (updating) { return; - } else { - updating = true; } + updating = true; + #if defined(PATCHAGE_LIBJACK) || defined(HAVE_JACK_DBUS) if (_jack_driver->is_attached()) { const jack_nframes_t buffer_size = _jack_driver->buffer_size(); |