From 07ca96e059ae22420cd3fd3902a989993ec66766 Mon Sep 17 00:00:00 2001 From: David Robillard Date: Fri, 11 Oct 2024 18:29:18 -0400 Subject: Return larger values from accessors by const reference --- .suppress.cppcheck | 1 - src/CanvasModule.hpp | 2 +- src/CanvasPort.hpp | 2 +- 3 files changed, 2 insertions(+), 3 deletions(-) diff --git a/.suppress.cppcheck b/.suppress.cppcheck index d9c8659..6faa54c 100644 --- a/.suppress.cppcheck +++ b/.suppress.cppcheck @@ -4,6 +4,5 @@ constVariableReference duplicateBreak missingReturn normalCheckLevelMaxBranches -returnByReference shadowFunction virtualCallInConstructor diff --git a/src/CanvasModule.hpp b/src/CanvasModule.hpp index e15a6b8..e0483cb 100644 --- a/src/CanvasModule.hpp +++ b/src/CanvasModule.hpp @@ -52,7 +52,7 @@ public: CanvasPort* get_port(const PortID& id); SignalDirection type() const { return _type; } - ClientID id() const { return _id; } + const ClientID& id() const { return _id; } const std::string& name() const { return _name; } protected: diff --git a/src/CanvasPort.hpp b/src/CanvasPort.hpp index 0fc2f04..b75ecf5 100644 --- a/src/CanvasPort.hpp +++ b/src/CanvasPort.hpp @@ -90,7 +90,7 @@ public: } PortType type() const { return _type; } - PortID id() const { return _id; } + const PortID& id() const { return _id; } const std::string& name() const { return _name; } const std::string& human_name() const { return _human_name; } const std::optional& order() const { return _order; } -- cgit v1.2.1