From 637e0fa1c4eb8aa9a4532db7dab0a6981f75b265 Mon Sep 17 00:00:00 2001 From: David Robillard Date: Sat, 15 Mar 2014 17:36:19 +0000 Subject: Fix crashes due to invalid format strings (fix #963). git-svn-id: http://svn.drobilla.net/lad/trunk/patchage@5337 a436a847-0d15-0410-975c-d299462d15a1 --- src/JackDriver.cpp | 2 +- src/PatchageCanvas.cpp | 5 ----- 2 files changed, 1 insertion(+), 6 deletions(-) (limited to 'src') diff --git a/src/JackDriver.cpp b/src/JackDriver.cpp index b60a5e1..b8ea2a4 100644 --- a/src/JackDriver.cpp +++ b/src/JackDriver.cpp @@ -186,7 +186,7 @@ JackDriver::create_port(PatchageModule& parent, jack_port_t* port, PortID id) } else if (!strcmp(type_str, JACK_DEFAULT_MIDI_TYPE)) { port_type = JACK_MIDI; } else { - _app->warning_msg((format("Jack: Port `%1%' has unknown type `%2'.") + _app->warning_msg((format("Jack: Port `%1%' has unknown type `%2%'.") % jack_port_name(port) % type_str).str()); return NULL; } diff --git a/src/PatchageCanvas.cpp b/src/PatchageCanvas.cpp index 976ab73..cbee58b 100644 --- a/src/PatchageCanvas.cpp +++ b/src/PatchageCanvas.cpp @@ -121,11 +121,6 @@ void PatchageCanvas::remove_port(const PortID& id) { PatchagePort* const port = find_port(id); - if (!port) { - _app->error_msg((format("Failed to find port with ID `%1' to remove.") - % id).str()); - } - _port_index.erase(id); delete port; } -- cgit v1.2.1