aboutsummaryrefslogtreecommitdiffstats
path: root/src/mac.m
diff options
context:
space:
mode:
authorDavid Robillard <d@drobilla.net>2021-12-17 10:43:11 -0500
committerDavid Robillard <d@drobilla.net>2021-12-17 11:18:04 -0500
commit6ca68635e8cef8407e91bc9542edf196ef708210 (patch)
tree3eac52f9fff833979e348b7e89b3a9f19628d34a /src/mac.m
parentcea2a9b9f454192bccb1bf0b1f5561d601022d00 (diff)
downloadpugl-6ca68635e8cef8407e91bc9542edf196ef708210.tar.gz
pugl-6ca68635e8cef8407e91bc9542edf196ef708210.tar.bz2
pugl-6ca68635e8cef8407e91bc9542edf196ef708210.zip
Make button numbers consistent across platforms
There's no universal consensus on how buttons are numbered. Left, right, middle as 0, 1, 2 seems to be the most common convention on modern vaguely similar libraries, so I've gone with that. The switch to zero-based indices will obviously break all current client code. Particularly since now is the time to finish any breaking changes before a stable release, I think that is better than only changing the middle and right numbers, which would likely go unnoticed.
Diffstat (limited to 'src/mac.m')
-rw-r--r--src/mac.m4
1 files changed, 2 insertions, 2 deletions
diff --git a/src/mac.m b/src/mac.m
index 5a10964..84530b4 100644
--- a/src/mac.m
+++ b/src/mac.m
@@ -448,7 +448,7 @@ handleCrossing(PuglWrapperView* view, NSEvent* event, const PuglEventType type)
rloc.x,
[[NSScreen mainScreen] frame].size.height - rloc.y,
getModifiers(event),
- (uint32_t)[event buttonNumber] + 1,
+ (uint32_t)[event buttonNumber],
};
PuglEvent pressEvent;
@@ -469,7 +469,7 @@ handleCrossing(PuglWrapperView* view, NSEvent* event, const PuglEventType type)
rloc.x,
[[NSScreen mainScreen] frame].size.height - rloc.y,
getModifiers(event),
- (uint32_t)[event buttonNumber] + 1,
+ (uint32_t)[event buttonNumber],
};
PuglEvent releaseEvent;