From 0495c381d065713852ee9e61df544ba531223824 Mon Sep 17 00:00:00 2001
From: David Robillard <d@drobilla.net>
Date: Thu, 12 Nov 2020 01:43:47 +0100
Subject: Use separate clang-tidy configurations for headers and tests

---
 .clang-tidy             | 38 --------------------------------------
 include/.clang-tidy     | 28 ++++++++++++++++++++++++++++
 include/raul/Socket.hpp |  4 ++--
 test/.clang-tidy        | 31 +++++++++++++++++++++++++++++++
 wscript                 |  2 +-
 5 files changed, 62 insertions(+), 41 deletions(-)
 delete mode 100644 .clang-tidy
 create mode 100644 include/.clang-tidy
 create mode 100644 test/.clang-tidy

diff --git a/.clang-tidy b/.clang-tidy
deleted file mode 100644
index c22be8b..0000000
--- a/.clang-tidy
+++ /dev/null
@@ -1,38 +0,0 @@
-Checks: >
-  *,
-  -*-avoid-c-arrays,
-  -*-magic-numbers,
-  -*-uppercase-literal-suffix,
-  -android*,
-  -bugprone-branch-clone,
-  -clang-analyzer-alpha.*,
-  -cppcoreguidelines-no-malloc,
-  -cppcoreguidelines-owning-memory,
-  -cppcoreguidelines-pro-bounds-array-to-pointer-decay,
-  -cppcoreguidelines-pro-bounds-pointer-arithmetic,
-  -cppcoreguidelines-pro-type-const-cast,
-  -cppcoreguidelines-pro-type-reinterpret-cast,
-  -cppcoreguidelines-pro-type-vararg,
-  -cppcoreguidelines-special-member-functions,
-  -fuchsia-default-arguments-*,
-  -fuchsia-overloaded-operator,
-  -google-runtime-int,
-  -google-runtime-references,
-  -hicpp-no-array-decay,
-  -hicpp-no-malloc,
-  -hicpp-signed-bitwise,
-  -hicpp-special-member-functions,
-  -hicpp-vararg,
-  -llvm-header-guard,
-  -misc-suspicious-string-compare,
-  -misc-unused-parameters,
-  -modernize-make-unique,
-  -modernize-use-trailing-return-type,
-  -readability-else-after-return,
-  -readability-implicit-bool-conversion,
-  -readability-make-member-function-const,
-WarningsAsErrors: '*'
-HeaderFilterRegex: '.*'
-FormatStyle: file
-
-
diff --git a/include/.clang-tidy b/include/.clang-tidy
new file mode 100644
index 0000000..3ed1d44
--- /dev/null
+++ b/include/.clang-tidy
@@ -0,0 +1,28 @@
+Checks: >
+  *,
+  -*-avoid-c-arrays,
+  -*-magic-numbers,
+  -*-no-malloc,
+  -*-special-member-functions,
+  -*-uppercase-literal-suffix,
+  -android-cloexec-accept,
+  -bugprone-branch-clone,
+  -clang-diagnostic-unused-macros,
+  -cppcoreguidelines-owning-memory,
+  -cppcoreguidelines-pro-bounds-array-to-pointer-decay,
+  -cppcoreguidelines-pro-bounds-pointer-arithmetic,
+  -cppcoreguidelines-pro-type-const-cast,
+  -cppcoreguidelines-pro-type-reinterpret-cast,
+  -fuchsia-default-arguments-calls,
+  -fuchsia-default-arguments-declarations,
+  -fuchsia-overloaded-operator,
+  -google-runtime-int,
+  -hicpp-no-array-decay,
+  -modernize-use-trailing-return-type,
+  -readability-else-after-return,
+  -readability-implicit-bool-conversion,
+WarningsAsErrors: '*'
+HeaderFilterRegex: '.*'
+FormatStyle: file
+
+
diff --git a/include/raul/Socket.hpp b/include/raul/Socket.hpp
index ed5204f..96ce597 100644
--- a/include/raul/Socket.hpp
+++ b/include/raul/Socket.hpp
@@ -203,7 +203,7 @@ Socket::connect(const std::string& uri)
 }
 
 inline bool
-Socket::listen()
+Socket::listen() // NOLINT(readability-make-member-function-const)
 {
 	return ::listen(_sock, 64) != -1;
 }
@@ -246,7 +246,7 @@ Socket::close()
 }
 
 inline void
-Socket::shutdown()
+Socket::shutdown() // NOLINT(readability-make-member-function-const)
 {
 	if (_sock != -1) {
 		::shutdown(_sock, SHUT_RDWR);
diff --git a/test/.clang-tidy b/test/.clang-tidy
new file mode 100644
index 0000000..57fec1f
--- /dev/null
+++ b/test/.clang-tidy
@@ -0,0 +1,31 @@
+Checks: >
+  *,
+  -*-avoid-c-arrays,
+  -*-magic-numbers,
+  -*-special-member-functions,
+  -*-uppercase-literal-suffix,
+  -*-vararg,
+  -android-cloexec-accept,  
+  -bugprone-branch-clone,
+  -cppcoreguidelines-no-malloc,
+  -cppcoreguidelines-owning-memory,
+  -cppcoreguidelines-pro-bounds-array-to-pointer-decay,
+  -cppcoreguidelines-pro-bounds-pointer-arithmetic,
+  -cppcoreguidelines-pro-type-const-cast,
+  -cppcoreguidelines-pro-type-reinterpret-cast,
+  -fuchsia-default-arguments-*,
+  -fuchsia-overloaded-operator,
+  -google-runtime-int,
+  -google-runtime-references,
+  -hicpp-no-array-decay,
+  -hicpp-no-malloc,
+  -hicpp-signed-bitwise,
+  -modernize-make-unique,
+  -modernize-use-trailing-return-type,
+  -readability-else-after-return,
+  -readability-implicit-bool-conversion,
+WarningsAsErrors: '*'
+HeaderFilterRegex: '.*'
+FormatStyle: file
+
+
diff --git a/wscript b/wscript
index ebddb46..59e5a07 100644
--- a/wscript
+++ b/wscript
@@ -175,7 +175,7 @@ def lint(ctx):
 
     if "CLANG_TIDY" in ctx.env and "clang" in ctx.env.CXX[0]:
         Logs.info("Running clang-tidy")
-        sources = glob.glob('test/*.cpp')
+        sources = glob.glob('test/*.cpp') + glob.glob('include/raul/*.hpp')
         sources = list(map(os.path.abspath, sources))
         procs = []
         for source in sources:
-- 
cgit v1.2.1