From 837179db6484241cebfb64ec7cf929cc58b7a42a Mon Sep 17 00:00:00 2001 From: David Robillard Date: Sat, 28 Sep 2024 14:02:00 -0400 Subject: Check variables in unit tests Avoid seemingly unused variables by checking something about them, even though the main point of the test is to check something else. Check accepted connections in socket test --- test/maid_test.cpp | 3 +++ test/socket_test.cpp | 5 ++++- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/test/maid_test.cpp b/test/maid_test.cpp index 0456913..fbd278a 100644 --- a/test/maid_test.cpp +++ b/test/maid_test.cpp @@ -65,8 +65,10 @@ test() { assert(n_junk == 0); const Maid::managed_ptr a = maid.make_managed(1U); + assert(a->value() == 1U); assert(n_junk == 1); const Maid::managed_ptr b = maid.make_managed(2U); + assert(b->value() == 2U); assert(n_junk == 2); } @@ -119,6 +121,7 @@ test() // Allocate a new object, then let it and the Maid go out of scope const Maid::managed_ptr c = maid.make_managed(5U); + assert(c->value() == 5U); assert(n_junk == 1); } diff --git a/test/socket_test.cpp b/test/socket_test.cpp index b29788c..1f2d736 100644 --- a/test/socket_test.cpp +++ b/test/socket_test.cpp @@ -60,11 +60,15 @@ main() if (pfds[0].revents & POLLIN) { const std::shared_ptr conn = unix_server_sock.accept(); + assert(conn); + assert(conn->fd()); ++n_received; } if (pfds[1].revents & POLLIN) { const std::shared_ptr conn = tcp_server_sock.accept(); + assert(conn); + assert(conn->fd()); ++n_received; } } @@ -72,7 +76,6 @@ main() unix_server_sock.shutdown(); tcp_server_sock.shutdown(); unlink("/tmp/raul_test_sock"); - fprintf(stderr, "n received: %u\n", n_received); return n_received != 2; } -- cgit v1.2.1