From f58a928dc15a0b8fe58d5a242b071f67e14c08dd Mon Sep 17 00:00:00 2001 From: David Robillard Date: Wed, 20 Jul 2022 11:06:22 -0400 Subject: Remove redundant inheritance from Noncopyable All copy/move methods are explicitly specified by these classes, so inheriting from Noncopyable didn't do anything useful. It should probably be removed as non-idiomatic. --- include/raul/Maid.hpp | 3 +-- include/raul/RingBuffer.hpp | 4 +--- include/raul/Socket.hpp | 4 +--- 3 files changed, 3 insertions(+), 8 deletions(-) (limited to 'include/raul') diff --git a/include/raul/Maid.hpp b/include/raul/Maid.hpp index 31a7331..2ca6fad 100644 --- a/include/raul/Maid.hpp +++ b/include/raul/Maid.hpp @@ -5,7 +5,6 @@ #define RAUL_MAID_HPP #include "raul/Deletable.hpp" -#include "raul/Noncopyable.hpp" #include #include @@ -24,7 +23,7 @@ namespace raul { @ingroup raul */ -class Maid : public Noncopyable +class Maid { public: /// An object that can be disposed via Maid::dispose() diff --git a/include/raul/RingBuffer.hpp b/include/raul/RingBuffer.hpp index acb4115..04f7cd7 100644 --- a/include/raul/RingBuffer.hpp +++ b/include/raul/RingBuffer.hpp @@ -4,8 +4,6 @@ #ifndef RAUL_RINGBUFFER_HPP #define RAUL_RINGBUFFER_HPP -#include "raul/Noncopyable.hpp" - #include #include #include @@ -22,7 +20,7 @@ namespace raul { @ingroup raul */ -class RingBuffer : public Noncopyable +class RingBuffer { public: /** diff --git a/include/raul/Socket.hpp b/include/raul/Socket.hpp index 28a3c3a..4a66d0b 100644 --- a/include/raul/Socket.hpp +++ b/include/raul/Socket.hpp @@ -4,8 +4,6 @@ #ifndef RAUL_SOCKET_HPP #define RAUL_SOCKET_HPP -#include "raul/Noncopyable.hpp" - #include #include #include @@ -24,7 +22,7 @@ namespace raul { @ingroup raul */ -class Socket : public raul::Noncopyable +class Socket { public: enum class Type { UNIX, TCP }; -- cgit v1.2.1