aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDavid Robillard <d@drobilla.net>2018-02-04 20:49:28 +0100
committerDavid Robillard <d@drobilla.net>2019-12-19 10:21:37 -0500
commita4296843ae313a8371d4464af3b7b59801f16438 (patch)
tree2d1b83677ec7766604e392e9a71634f38a995f69
parent82af4d09d7f08f25c160971e92d760b0147ad0fa (diff)
downloadserd-a4296843ae313a8371d4464af3b7b59801f16438.tar.gz
serd-a4296843ae313a8371d4464af3b7b59801f16438.tar.bz2
serd-a4296843ae313a8371d4464af3b7b59801f16438.zip
Remove serd_uri_to_path()
-rw-r--r--NEWS1
-rw-r--r--serd/serd.h11
-rw-r--r--src/serdi.c9
-rw-r--r--src/uri.c23
-rw-r--r--tests/serd_test.c29
5 files changed, 8 insertions, 65 deletions
diff --git a/NEWS b/NEWS
index 95850cfc..54790d5c 100644
--- a/NEWS
+++ b/NEWS
@@ -4,6 +4,7 @@ serd (1.0.1) unstable;
* Make nodes opaque
* Make serd_strtod API const-correct
* Make serd_strtod API const-correct
+ * Remove half-baked serd_uri_to_path()
* Remove useless character counting from API
* Rename SerdChunk to SerdStringView
* Use char* for strings in public API
diff --git a/serd/serd.h b/serd/serd.h
index f09d2ea8..32dbe21e 100644
--- a/serd/serd.h
+++ b/serd/serd.h
@@ -376,17 +376,6 @@ static const SerdURI SERD_URI_NULL = {
};
/**
- Return the local path for `uri`, or NULL if `uri` is not a file URI.
- Note this (inappropriately named) function only removes the file scheme if
- necessary, and returns `uri` unmodified if it is an absolute path. Percent
- encoding and other issues are not handled, to properly convert a file URI to
- a path, use serd_file_uri_parse().
-*/
-SERD_API
-const char*
-serd_uri_to_path(const char* uri);
-
-/**
Get the unescaped path and hostname from a file URI.
@param uri A file URI.
@param hostname If non-NULL, set to the hostname, if present.
diff --git a/src/serdi.c b/src/serdi.c
index f6b7c529..a631aebf 100644
--- a/src/serdi.c
+++ b/src/serdi.c
@@ -211,11 +211,15 @@ main(int argc, char** argv)
_setmode(fileno(stdout), _O_BINARY);
#endif
- const char* input = (const char*)argv[a++];
+ char* input_path = NULL;
+ const char* input = (const char*)argv[a++];
if (from_file) {
in_name = in_name ? in_name : input;
if (!in_fd) {
- input = serd_uri_to_path(in_name);
+ if (!strncmp(input, "file:", 5)) {
+ input_path = serd_file_uri_parse(input, NULL);
+ input = input_path;
+ }
if (!input || !(in_fd = serd_fopen(input, "rb"))) {
return 1;
}
@@ -306,6 +310,7 @@ main(int argc, char** argv)
serd_writer_free(writer);
serd_env_free(env);
serd_node_free(base);
+ free(input_path);
if (from_file) {
fclose(in_fd);
diff --git a/src/uri.c b/src/uri.c
index 0b0e8848..a5104eb2 100644
--- a/src/uri.c
+++ b/src/uri.c
@@ -19,29 +19,6 @@
#include <stdlib.h>
#include <string.h>
-const char*
-serd_uri_to_path(const char* uri)
-{
- const char* path = uri;
- if (!is_windows_path(uri) && serd_uri_string_has_scheme(uri)) {
- if (strncmp(uri, "file:", 5)) {
- fprintf(stderr, "Non-file URI `%s'\n", uri);
- return NULL;
- } else if (!strncmp(uri, "file://localhost/", 17)) {
- path = uri + 16;
- } else if (!strncmp(uri, "file://", 7)) {
- path = uri + 7;
- } else {
- fprintf(stderr, "Invalid file URI `%s'\n", uri);
- return NULL;
- }
- if (is_windows_path(path + 1)) {
- ++path; // Special case for terrible Windows file URIs
- }
- }
- return path;
-}
-
char*
serd_file_uri_parse(const char* uri, char** hostname)
{
diff --git a/tests/serd_test.c b/tests/serd_test.c
index af1a2110..c15f45d3 100644
--- a/tests/serd_test.c
+++ b/tests/serd_test.c
@@ -302,34 +302,6 @@ test_strerror(void)
}
static void
-test_uri_to_path(void)
-{
- const char* uri = "file:///home/user/foo.ttl";
- assert(!strcmp(serd_uri_to_path(uri), "/home/user/foo.ttl"));
-
- uri = "file://localhost/home/user/foo.ttl";
- assert(!strcmp(serd_uri_to_path(uri), "/home/user/foo.ttl"));
-
- uri = "file:illegal/file/uri";
- assert(!serd_uri_to_path(uri));
-
- uri = "file:///c:/awful/system";
- assert(!strcmp(serd_uri_to_path(uri), "c:/awful/system"));
-
- uri = "file:///c:awful/system";
- assert(!strcmp(serd_uri_to_path(uri), "/c:awful/system"));
-
- uri = "file:///0/1";
- assert(!strcmp(serd_uri_to_path(uri), "/0/1"));
-
- uri = "C:\\Windows\\Sucks";
- assert(!strcmp(serd_uri_to_path(uri), "C:\\Windows\\Sucks"));
-
- uri = "C|/Windows/Sucks";
- assert(!strcmp(serd_uri_to_path(uri), "C|/Windows/Sucks"));
-}
-
-static void
test_uri_parsing(void)
{
test_file_uri(NULL, "C:/My 100%", true,
@@ -659,7 +631,6 @@ main(void)
test_blob_to_node();
test_strlen();
test_strerror();
- test_uri_to_path();
test_uri_parsing();
test_node_equals();
test_node_from_string();