diff options
author | David Robillard <d@drobilla.net> | 2022-01-02 14:12:54 -0500 |
---|---|---|
committer | David Robillard <d@drobilla.net> | 2022-01-28 21:57:05 -0500 |
commit | 155fceabe7070b6610d577734734d038d097b088 (patch) | |
tree | 5bbbf327a00c2637f85f006c4b429ecc3b3cb1a3 /src/node_syntax.c | |
parent | 1159aea45d9bc4ade2e82856be403d58e050f32d (diff) | |
download | serd-155fceabe7070b6610d577734734d038d097b088.tar.gz serd-155fceabe7070b6610d577734734d038d097b088.tar.bz2 serd-155fceabe7070b6610d577734734d038d097b088.zip |
Add assertions for all non-null pointers in the public API
Clang issues warnings at build time based on the SERD_NONNULL annotations,
which is a much better approach in general. However, it does not cover cases
where the API is being used with another compiler, or without a compiler that
can statically check things at all (such as Python or other dynamic language
bindings).
In those situations, getting a clear assertion message is a lot less confusing
than a random crash somewhere in serd, and it makes it clear that the bug is in
the caller, so I think it's worth the tedious verbosity.
Diffstat (limited to 'src/node_syntax.c')
-rw-r--r-- | src/node_syntax.c | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/src/node_syntax.c b/src/node_syntax.c index 626648f6..ff8c32d4 100644 --- a/src/node_syntax.c +++ b/src/node_syntax.c @@ -18,6 +18,7 @@ #include "serd/serd.h" +#include <assert.h> #include <stdio.h> #include <stdlib.h> #include <string.h> @@ -38,6 +39,8 @@ serd_node_from_syntax_in(const char* const str, const SerdSyntax syntax, SerdEnv* const env) { + assert(str); + static const char* const prelude = "_:s <http://www.w3.org/2000/01/rdf-schema#object>"; @@ -72,6 +75,8 @@ serd_node_from_syntax(const char* const str, const SerdSyntax syntax, SerdEnv* const env) { + assert(str); + if (env) { return serd_node_from_syntax_in(str, syntax, env); } @@ -110,6 +115,8 @@ serd_node_to_syntax(const SerdNode* const node, const SerdSyntax syntax, const SerdEnv* const env) { + assert(node); + if (env) { return serd_node_to_syntax_in(node, syntax, env); } |