diff options
author | David Robillard <d@drobilla.net> | 2022-01-02 14:12:54 -0500 |
---|---|---|
committer | David Robillard <d@drobilla.net> | 2022-01-28 21:57:05 -0500 |
commit | 155fceabe7070b6610d577734734d038d097b088 (patch) | |
tree | 5bbbf327a00c2637f85f006c4b429ecc3b3cb1a3 /src/nodes.c | |
parent | 1159aea45d9bc4ade2e82856be403d58e050f32d (diff) | |
download | serd-155fceabe7070b6610d577734734d038d097b088.tar.gz serd-155fceabe7070b6610d577734734d038d097b088.tar.bz2 serd-155fceabe7070b6610d577734734d038d097b088.zip |
Add assertions for all non-null pointers in the public API
Clang issues warnings at build time based on the SERD_NONNULL annotations,
which is a much better approach in general. However, it does not cover cases
where the API is being used with another compiler, or without a compiler that
can statically check things at all (such as Python or other dynamic language
bindings).
In those situations, getting a clear assertion message is a lot less confusing
than a random crash somewhere in serd, and it makes it clear that the bug is in
the caller, so I think it's worth the tedious verbosity.
Diffstat (limited to 'src/nodes.c')
-rw-r--r-- | src/nodes.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/src/nodes.c b/src/nodes.c index a7d0ab2b..5c6492e4 100644 --- a/src/nodes.c +++ b/src/nodes.c @@ -225,6 +225,8 @@ serd_nodes_free(SerdNodes* nodes) size_t serd_nodes_size(const SerdNodes* nodes) { + assert(nodes); + return zix_hash_size(nodes->hash); } @@ -257,6 +259,8 @@ serd_nodes_intern(SerdNodes* nodes, const SerdNode* node) const SerdNode* serd_nodes_get(const SerdNodes* const nodes, const SerdNode* const node) { + assert(nodes); + if (!node) { return NULL; } |