diff options
| -rw-r--r-- | serd/serd.h | 4 | ||||
| -rw-r--r-- | src/node.c | 14 | ||||
| -rw-r--r-- | tests/serd_test.c | 12 |
3 files changed, 20 insertions, 10 deletions
diff --git a/serd/serd.h b/serd/serd.h index 7aa0ebdd..41ce9820 100644 --- a/serd/serd.h +++ b/serd/serd.h @@ -481,7 +481,9 @@ serd_node_new_substring(SerdType type, const char* str, size_t len); */ SERD_API SerdNode* -serd_node_new_literal(const char* str, const char* datatype, const char* lang); +serd_node_new_literal(const char* str, + const SerdNode* datatype, + const char* lang); /** Return a deep copy of `node`. @@ -117,9 +117,13 @@ serd_node_new_substring(SerdType type, const char* str, const size_t len) } SerdNode* -serd_node_new_literal(const char* str, const char* datatype, const char* lang) +serd_node_new_literal(const char* str, + const SerdNode* datatype, + const char* lang) { - if (!str || (lang && datatype && strcmp(datatype, NS_RDF "#langString"))) { + if (!str || (lang && datatype && + strcmp(serd_node_buffer_c(datatype), NS_RDF "langString")) || + (datatype && serd_node_get_type(datatype) != SERD_URI)) { return NULL; } @@ -142,16 +146,14 @@ serd_node_new_literal(const char* str, const char* datatype, const char* lang) memcpy(serd_node_buffer(lang_node), lang, lang_len); } else if (datatype) { flags |= SERD_HAS_DATATYPE; - const size_t datatype_len = strlen(datatype); + const size_t datatype_len = strlen(serd_node_buffer_c(datatype)); const size_t total_len = len + sizeof(SerdNode) + datatype_len; node = serd_node_malloc(total_len, flags, SERD_LITERAL); memcpy(serd_node_buffer(node), str, n_bytes); node->n_bytes = n_bytes; SerdNode* datatype_node = node + 1 + (len / serd_node_align); - datatype_node->type = SERD_URI; - datatype_node->n_bytes = datatype_len; - memcpy(serd_node_buffer(datatype_node), datatype, datatype_len); + memcpy(datatype_node, datatype, sizeof(SerdNode) + datatype_len); } else { node = serd_node_malloc(n_bytes, flags, SERD_LITERAL); memcpy(serd_node_buffer(node), str, n_bytes); diff --git a/tests/serd_test.c b/tests/serd_test.c index ba8ca2ce..4d31cbe3 100644 --- a/tests/serd_test.c +++ b/tests/serd_test.c @@ -400,8 +400,10 @@ static void test_literal(void) "en")); serd_node_free(hello_l); - SerdNode* hello_dt = serd_node_new_literal( - "hello_dt\"", "http://example.org/Thing", NULL); + SerdNode* eg_Thing = serd_node_new_uri_from_string( + "http://example.org/Thing", NULL, NULL); + + SerdNode* hello_dt = serd_node_new_literal("hello_dt\"", eg_Thing, NULL); assert(serd_node_get_length(hello_dt) == 9); assert(!strcmp(serd_node_get_string(hello_dt), "hello_dt\"")); assert(serd_node_get_flags(hello_dt) == @@ -409,6 +411,7 @@ static void test_literal(void) assert(!strcmp(serd_node_get_string(serd_node_get_datatype(hello_dt)), "http://example.org/Thing")); serd_node_free(hello_dt); + serd_node_free(eg_Thing); } static void @@ -576,7 +579,9 @@ test_writer(const char* const path) junk[i][0], junk[i][1], junk[i][2])); } - SerdNode* t = serd_node_new_literal((char*)buf, "urn:Type", NULL); + SerdNode* urn_Type = serd_node_new_uri_from_string("urn:Type", NULL, NULL); + + SerdNode* t = serd_node_new_literal((char*)buf, urn_Type, NULL); SerdNode* l = serd_node_new_literal((char*)buf, NULL, "en"); const SerdNode* good[][5] = { { s, p, o }, { s, p, o }, @@ -614,6 +619,7 @@ test_writer(const char* const path) serd_node_free(o); serd_node_free(t); serd_node_free(l); + serd_node_free(urn_Type); // Test buffer sink SerdBuffer buffer = { NULL, 0 }; |