From 6e93b7e893fbb8e7f079c296688d1b8f2f9c5ea2 Mon Sep 17 00:00:00 2001 From: David Robillard Date: Wed, 11 Dec 2024 19:37:46 -0500 Subject: Fix potential use before null check --- src/x11_util.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) (limited to 'src') diff --git a/src/x11_util.c b/src/x11_util.c index f5f1c87..3662594 100644 --- a/src/x11_util.c +++ b/src/x11_util.c @@ -19,17 +19,14 @@ suil_x11_is_valid_child(Display* const display, unsigned n_children = 0U; XQueryTree(display, parent, &root, &grandparent, &children, &n_children); - - for (unsigned i = 0U; i < n_children; ++i) { - if (children[i] == child) { - if (children) { + if (children) { + for (unsigned i = 0U; i < n_children; ++i) { + if (children[i] == child) { XFree(children); + return true; } - return true; } - } - if (children) { XFree(children); } -- cgit v1.2.1