diff options
| author | Tim-Philipp Müller <tim@centricular.net> | 2006-08-23 10:30:31 +0000 |
|---|---|---|
| committer | Tim-Philipp Müller <tim@centricular.net> | 2006-08-23 10:30:31 +0000 |
| commit | 2d7cf5f38549d6e18f124e3171c8687640b3eb35 (patch) | |
| tree | 34bf67fc7619d66ff653d6261c86e1942bc1f7ea | |
| parent | 4bd2320e4ca7d62fb7c47c09c33f0479d2e9e7f0 (diff) | |
| download | gst-plugins-bad-2d7cf5f38549d6e18f124e3171c8687640b3eb35.tar.gz gst-plugins-bad-2d7cf5f38549d6e18f124e3171c8687640b3eb35.tar.bz2 gst-plugins-bad-2d7cf5f38549d6e18f124e3171c8687640b3eb35.zip | |
ext/wavpack/gstwavpackenc.c: Fix mem leak, send newsegment event on correction pad as well (#352476).
Original commit message from CVS:
* ext/wavpack/gstwavpackenc.c: (gst_wavpack_enc_push_block):
Fix mem leak, send newsegment event on correction pad
as well (#352476).
* ext/wavpack/gstwavpackparse.c: (gst_wavpack_parse_base_init):
Restore original author (on Sebastian's request).
* tests/check/Makefile.am:
* tests/check/gst-plugins-bad.supp:
Add (so far empty) suppression file for -bad. Remove
wavpackenc test from VALGRIND_TO_FIX now that the leak
is fixed.
| -rw-r--r-- | ChangeLog | 15 | ||||
| m--------- | common | 0 | ||||
| -rw-r--r-- | ext/wavpack/gstwavpackenc.c | 6 | ||||
| -rw-r--r-- | ext/wavpack/gstwavpackparse.c | 2 | ||||
| -rw-r--r-- | tests/check/Makefile.am | 5 | ||||
| -rw-r--r-- | tests/check/gst-plugins-bad.supp | 0 |
6 files changed, 21 insertions, 7 deletions
@@ -1,5 +1,20 @@ 2006-08-23 Tim-Philipp Müller <tim at centricular dot net> + * ext/wavpack/gstwavpackenc.c: (gst_wavpack_enc_push_block): + Fix mem leak, send newsegment event on correction pad + as well (#352476). + + * ext/wavpack/gstwavpackparse.c: (gst_wavpack_parse_base_init): + Restore original author (on Sebastian's request). + + * tests/check/Makefile.am: + * tests/check/gst-plugins-bad.supp: + Add (so far empty) suppression file for -bad. Remove + wavpackenc test from VALGRIND_TO_FIX now that the leak + is fixed. + +2006-08-23 Tim-Philipp Müller <tim at centricular dot net> + Patch by: Sebastian Dröge <slomo at circular-chaos.org> * tests/check/Makefile.am: diff --git a/common b/common -Subproject e9ea99f6e89d7e1af3a0a859bfeb0ed6ecf2e3a +Subproject d287125f93da692bc25d53b0b7b0e2f90424a21 diff --git a/ext/wavpack/gstwavpackenc.c b/ext/wavpack/gstwavpackenc.c index 19ad0923..22d8f976 100644 --- a/ext/wavpack/gstwavpackenc.c +++ b/ext/wavpack/gstwavpackenc.c @@ -562,13 +562,13 @@ gst_wavpack_enc_push_block (void *id, void *data, int32_t count) /* if it's the first wavpack block, send a NEW_SEGMENT event */ if (wph.block_index == 0) { - GstEvent *event = gst_event_new_new_segment (FALSE, - 1.0, GST_FORMAT_BYTES, 0, GST_BUFFER_OFFSET_NONE, 0); + gst_pad_push_event (pad, + gst_event_new_new_segment (FALSE, + 1.0, GST_FORMAT_BYTES, 0, GST_BUFFER_OFFSET_NONE, 0)); /* save header for later reference, so we can re-send it later on * EOS with fixed up values for total sample count etc. */ if (enc->first_block == NULL && !wid->correction) { - gst_pad_push_event (enc->srcpad, event); enc->first_block = g_memdup (block, count); enc->first_block_size = count; } diff --git a/ext/wavpack/gstwavpackparse.c b/ext/wavpack/gstwavpackparse.c index ca894ec9..d252ccfb 100644 --- a/ext/wavpack/gstwavpackparse.c +++ b/ext/wavpack/gstwavpackparse.c @@ -97,7 +97,7 @@ gst_wavpack_parse_base_init (gpointer klass) GST_ELEMENT_DETAILS ("WavePack parser", "Codec/Demuxer/Audio", "Parses Wavpack files", - "Sebastian Dröge <slomo@circular-chaos.org>"); + "Arwed v. Merkatz <v.merkatz@gmx.net>"); GstElementClass *element_class = GST_ELEMENT_CLASS (klass); gst_element_class_add_pad_template (element_class, diff --git a/tests/check/Makefile.am b/tests/check/Makefile.am index 1c520254..e85d5c8b 100644 --- a/tests/check/Makefile.am +++ b/tests/check/Makefile.am @@ -22,7 +22,7 @@ install-pluginLTLIBRARIES: # the core dumps of some machines have PIDs appended CLEANFILES = core.* test-registry.xml -SUPPRESSIONS = $(top_srcdir)/common/gst.supp +SUPPRESSIONS = $(top_srcdir)/common/gst.supp $(srcdir)/gst-plugins-bad.supp clean-local: clean-local-check @@ -42,8 +42,7 @@ check_wavpack = endif VALGRIND_TO_FIX = \ - elements/mpeg2enc \ - elements/wavpackenc + elements/mpeg2enc # valgrind testing VALGRIND_TESTS_DISABLE = $(VALGRIND_TO_FIX) diff --git a/tests/check/gst-plugins-bad.supp b/tests/check/gst-plugins-bad.supp new file mode 100644 index 00000000..e69de29b --- /dev/null +++ b/tests/check/gst-plugins-bad.supp |