summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorThomas Vander Stichele <thomas@apestaart.org>2004-02-12 18:18:51 +0000
committerThomas Vander Stichele <thomas@apestaart.org>2004-02-12 18:18:51 +0000
commit6484fedb8d906a9eafc412c38323f3cf4f1ca0da (patch)
treecf8335f44cf536b8e59d832da519563d0ba16676
parent2a84336a8e5ab47c6eca4eb8fc97d44794443d8a (diff)
downloadgst-plugins-bad-6484fedb8d906a9eafc412c38323f3cf4f1ca0da.tar.gz
gst-plugins-bad-6484fedb8d906a9eafc412c38323f3cf4f1ca0da.tar.bz2
gst-plugins-bad-6484fedb8d906a9eafc412c38323f3cf4f1ca0da.zip
fixes for #133316, #133663 and #133528 (Stefan Kost)
Original commit message from CVS: fixes for #133316, #133663 and #133528 (Stefan Kost)
-rw-r--r--ChangeLog12
m---------common0
-rw-r--r--ext/ladspa/gstladspa.c19
-rw-r--r--gst/vbidec/vbiscreen.c2
4 files changed, 24 insertions, 9 deletions
diff --git a/ChangeLog b/ChangeLog
index a768df71..07f8ff71 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,15 @@
+2004-02-12 Thomas Vander Stichele <thomas at apestaart dot org>
+
+ * ext/ladspa/gstladspa.c: (gst_ladspa_base_init):
+ classify LADSPA plugins based on number of src/sink pads
+ (#133663, Stefan Kost)
+ * gst/sine/gstsinesrc.c: (gst_sinesrc_init):
+ fix dparams registration
+ (#133528, Stefan Kost)
+ * gst/vbidec/vbiscreen.c: (vbiscreen_set_current_cell):
+ fix use of isprint and use g_ascii_isprint instead
+ (#133316, Stefan Kost)
+
2004-02-11 David Schleef <ds@schleef.org>
Convert a few inner loops to use liboil. This is currently
diff --git a/common b/common
-Subproject 59d3c4334b32261908261a163b4633532293492
+Subproject d7fa1407cff7d2054ba22ac6824eba4086fdd04
diff --git a/ext/ladspa/gstladspa.c b/ext/ladspa/gstladspa.c
index ff2711fc..020767fa 100644
--- a/ext/ladspa/gstladspa.c
+++ b/ext/ladspa/gstladspa.c
@@ -92,14 +92,6 @@ gst_ladspa_base_init (GstLADSPAClass *klass)
desc = g_hash_table_lookup(ladspa_descriptors, GINT_TO_POINTER(0));
g_assert (desc);
- /* construct the element details struct */
- details = g_new0(GstElementDetails,1);
- details->longname = g_strdup(desc->Name);
- details->klass = "Filter/Effect/Audio/LADSPA";
- details->description = details->longname;
- details->author = g_strdup(desc->Maker);
- gst_element_class_set_details (element_class, details);
-
/* pad templates */
klass->numports = desc->PortCount;
klass->numsinkpads = 0;
@@ -124,6 +116,17 @@ gst_ladspa_base_init (GstLADSPAClass *klass)
}
}
+ /* construct the element details struct */
+ details = g_new0(GstElementDetails,1);
+ details->longname = g_strdup(desc->Name);
+ details->description = details->longname;
+ details->author = g_strdup(desc->Maker);
+ if ((klass->numsinkpads >0) && (klass->numsrcpads >0)) details->klass = "Filter/Effect/Audio/LADSPA";
+ else if((klass->numsinkpads==0) && (klass->numsrcpads >0)) details->klass = "Source/Audio/LADSPA";
+ else if((klass->numsinkpads >0) && (klass->numsrcpads==0)) details->klass = "Sink/Audio/LADSPA";
+ else details->klass = "Filter/Effect/Audio/LADSPA"; /* whatever this is */
+ gst_element_class_set_details (element_class, details);
+
klass->srcpad_portnums = g_new0(gint,klass->numsrcpads);
klass->sinkpad_portnums = g_new0(gint,klass->numsinkpads);
sinkcount = 0;
diff --git a/gst/vbidec/vbiscreen.c b/gst/vbidec/vbiscreen.c
index 189591f1..bc315587 100644
--- a/gst/vbidec/vbiscreen.c
+++ b/gst/vbidec/vbiscreen.c
@@ -506,7 +506,7 @@ void vbiscreen_set_current_cell( vbiscreen_t *vs, char text )
int base;
if( !vs ) return;
base = ( ( vs->top_of_screen + vs->cury ) % ( 2 * ROWS ) ) * COLS;
- if( isprint( text ) )
+ if( g_ascii_isprint( text ) )
vs->text[ base + vs->curx + vs->indent ] = text;
else
vs->text[ base + vs->curx + vs->indent ] = ' ';