From 2edfcea585ee1ef195ca2ebad81f546a506a2ba0 Mon Sep 17 00:00:00 2001 From: Wim Taymans Date: Tue, 21 Aug 2007 17:18:29 +0000 Subject: gst/rtpmanager/gstrtpjitterbuffer.c: When drop-on-latency is set but we have no latency configured, just push the buf... Original commit message from CVS: * gst/rtpmanager/gstrtpjitterbuffer.c: (gst_rtp_jitter_buffer_chain), (gst_rtp_jitter_buffer_set_property): When drop-on-latency is set but we have no latency configured, just push the buffer as fast as possible. Fix typo in comment. --- ChangeLog | 9 +++++++++ gst/rtpmanager/gstrtpjitterbuffer.c | 10 ++++++---- 2 files changed, 15 insertions(+), 4 deletions(-) diff --git a/ChangeLog b/ChangeLog index 04ff10bf..d8c76fe7 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,12 @@ +2007-08-21 Wim Taymans + + * gst/rtpmanager/gstrtpjitterbuffer.c: + (gst_rtp_jitter_buffer_chain), + (gst_rtp_jitter_buffer_set_property): + When drop-on-latency is set but we have no latency configured, just push + the buffer as fast as possible. + Fix typo in comment. + 2007-08-21 Wim Taymans * gst/rtpmanager/rtpjitterbuffer.c: diff --git a/gst/rtpmanager/gstrtpjitterbuffer.c b/gst/rtpmanager/gstrtpjitterbuffer.c index e66613bb..f81c6329 100644 --- a/gst/rtpmanager/gstrtpjitterbuffer.c +++ b/gst/rtpmanager/gstrtpjitterbuffer.c @@ -807,8 +807,10 @@ gst_rtp_jitter_buffer_chain (GstPad * pad, GstBuffer * buffer) } /* let's drop oldest packet if the queue is already full and drop-on-latency - * is set. */ - if (priv->drop_on_latency) { + * is set. We can only do this when there actually is a latency. When no + * latency is set, we just pump it in the queue and let the other end push it + * out as fast as possible. */ + if (priv->latency_ms && priv->drop_on_latency) { guint64 latency_ts; latency_ts = @@ -1187,8 +1189,8 @@ gst_rtp_jitter_buffer_set_property (GObject * object, jitterbuffer->priv->latency_ms = new_latency; - /* post message if latency changed, this will infor the parent pipeline - * that a latency reconfiguration is possible. */ + /* post message if latency changed, this will inform the parent pipeline + * that a latency reconfiguration is possible/needed. */ if (new_latency != old_latency) { gst_element_post_message (GST_ELEMENT_CAST (jitterbuffer), gst_message_new_latency (GST_OBJECT_CAST (jitterbuffer))); -- cgit v1.2.1