From f1163bb16d8ae140ad0e81da779b10dd6a9015e8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tim-Philipp=20M=C3=BCller?= Date: Fri, 8 Sep 2006 16:47:46 +0000 Subject: configure.ac: Bump requirements of -base (videocrop test case needs this). Original commit message from CVS: * configure.ac: Bump requirements of -base (videocrop test case needs this). * gst/videocrop/gstvideocrop.c: Document sloppy handling of subsampled chroma planes if left/top cropping is an odd number. * tests/check/elements/videocrop.c: (handoff_cb), (videocrop_test_cropping_init_context), (videocrop_test_cropping_deinit_context), (videocrop_test_cropping), (check_1x1_buffer), (GST_START_TEST), (videocrop_suite), (main): Add another unit test that crops the input to 1x1 (and checks that that pixel has the expected values in a number of formats). --- gst/videocrop/gstvideocrop.c | 7 +++++++ 1 file changed, 7 insertions(+) (limited to 'gst') diff --git a/gst/videocrop/gstvideocrop.c b/gst/videocrop/gstvideocrop.c index c5b0ac90..3208e2a2 100644 --- a/gst/videocrop/gstvideocrop.c +++ b/gst/videocrop/gstvideocrop.c @@ -37,6 +37,13 @@ * * If there is nothing to crop, the element will operate in pass-through mode. * + * + * Note that no special efforts are made to handle chroma-subsampled formats + * in the case of odd-valued cropping and compensate for sub-unit chroma plane + * shifts for such formats in the case where the "left" or "top" property is + * set to an odd number. This doesn't matter for most use cases, but it might + * matter for yours. + * * Example launch line * * -- cgit v1.2.1