summaryrefslogtreecommitdiffstats
path: root/src/server/InputPort.hpp
diff options
context:
space:
mode:
authorDavid Robillard <d@drobilla.net>2016-12-13 17:51:55 -0500
committerDavid Robillard <d@drobilla.net>2016-12-13 19:15:29 -0500
commitad43d2e08cea225635b56c5473a768bc853ecda3 (patch)
tree472a8c6dc605ba63903206a14549e8340efcf137 /src/server/InputPort.hpp
parent0752556bde5659a933744658cdf63509000a5080 (diff)
downloadingen-ad43d2e08cea225635b56c5473a768bc853ecda3.tar.gz
ingen-ad43d2e08cea225635b56c5473a768bc853ecda3.tar.bz2
ingen-ad43d2e08cea225635b56c5473a768bc853ecda3.zip
Remove virtual inheritance from Port hierarchy
This was confusing stoat, and is questionable design anyway. The OutputPort functionality has been moved to PortImpl, which is a basic port with buffers suitable for use as an output, and is overridden by InputPort and DuplexPort where necessary.
Diffstat (limited to 'src/server/InputPort.hpp')
-rw-r--r--src/server/InputPort.hpp12
1 files changed, 4 insertions, 8 deletions
diff --git a/src/server/InputPort.hpp b/src/server/InputPort.hpp
index f93aa4df..1a27ac93 100644
--- a/src/server/InputPort.hpp
+++ b/src/server/InputPort.hpp
@@ -1,6 +1,6 @@
/*
This file is part of Ingen.
- Copyright 2007-2015 David Robillard <http://drobilla.net/>
+ Copyright 2007-2016 David Robillard <http://drobilla.net/>
Ingen is free software: you can redistribute it and/or modify it under the
terms of the GNU Affero General Public License as published by the Free
@@ -32,7 +32,6 @@ namespace Server {
class ArcImpl;
class BlockImpl;
-class OutputPort;
class RunContext;
/** An input port on a Block or Graph.
@@ -46,7 +45,7 @@ class RunContext;
*
* \ingroup engine
*/
-class InputPort : virtual public PortImpl
+class InputPort : public PortImpl
{
public:
InputPort(BufferFactory& bufs,
@@ -83,8 +82,8 @@ public:
*
* setup_buffers() must be called later for the change to take effect.
*/
- ArcImpl* remove_arc(RunContext& context,
- const OutputPort* tail);
+ ArcImpl* remove_arc(RunContext& context,
+ const PortImpl* tail);
/** Set `voices` as the buffers to be used for this port.
*
@@ -111,9 +110,6 @@ public:
void increment_num_arcs() { ++_num_arcs; }
void decrement_num_arcs() { --_num_arcs; }
- bool is_input() const { return true; }
- bool is_output() const { return false; }
-
bool direct_connect() const;
protected: