diff options
author | David Robillard <d@drobilla.net> | 2012-03-12 02:28:21 +0000 |
---|---|---|
committer | David Robillard <d@drobilla.net> | 2012-03-12 02:28:21 +0000 |
commit | e9d9569271ee962c09ab66c6babed1ca5655a6c6 (patch) | |
tree | f77142b08c2bf2488eb382e993da1477c0b94307 /src/server/events/CreateNode.cpp | |
parent | 7835b3d8c9b5b4a6f4959f56083d62826e6f7b8e (diff) | |
download | ingen-e9d9569271ee962c09ab66c6babed1ca5655a6c6.tar.gz ingen-e9d9569271ee962c09ab66c6babed1ca5655a6c6.tar.bz2 ingen-e9d9569271ee962c09ab66c6babed1ca5655a6c6.zip |
Unify event response mechanism and make it more appropriate for wire transmission.
The downside being more cryptic error messages until the client side error reporting stuff gets more fancy, but the important part is that belongs client side.
git-svn-id: http://svn.drobilla.net/lad/trunk/ingen@4053 a436a847-0d15-0410-975c-d299462d15a1
Diffstat (limited to 'src/server/events/CreateNode.cpp')
-rw-r--r-- | src/server/events/CreateNode.cpp | 27 |
1 files changed, 11 insertions, 16 deletions
diff --git a/src/server/events/CreateNode.cpp b/src/server/events/CreateNode.cpp index 04fef8b1..5fe7a86f 100644 --- a/src/server/events/CreateNode.cpp +++ b/src/server/events/CreateNode.cpp @@ -96,8 +96,9 @@ CreateNode::pre_process() } } - if (!_node) - _error = 1; + if (!_node) { + _status = FAILURE; + } Event::pre_process(); } @@ -116,22 +117,16 @@ CreateNode::execute(ProcessContext& context) void CreateNode::post_process() { - string msg; if (_node_already_exists) { - msg = string("Could not create node - ").append(_path.str());// + " already exists."; - respond_error(msg); - } else if (_patch == NULL) { - msg = "Could not find patch '" + _path.parent().str() +"' to add node."; - respond_error(msg); - } else if (_plugin == NULL) { - msg = "Unable to load node "; - msg += _path.str() + " (you're missing the plugin " + _plugin_uri.str() + ")"; - respond_error(msg); - } else if (_node == NULL) { - msg = "Failed to instantiate plugin " + _plugin_uri.str(); - respond_error(msg); + respond(EXISTS); + } else if (!_patch) { + respond(PARENT_NOT_FOUND); + } else if (!_plugin) { + respond(PLUGIN_NOT_FOUND); + } else if (!_node) { + respond(FAILURE); } else { - respond_ok(); + respond(SUCCESS); _engine.broadcaster()->send_object(_node, true); // yes, send ports } } |