path: root/src
AgeCommit message (Collapse)AuthorFilesLines
2020-08-02Fix self-assignmentDavid Robillard1-4/+6
2020-08-02Make move operators noexceptDavid Robillard1-2/+2
2020-08-02Remove unnecessary moveDavid Robillard1-1/+1
2020-08-02Fix whitespaceDavid Robillard1-2/+1
2020-08-02Add missing bracesDavid Robillard2-2/+4
2020-08-02Move public headers to a separate include directoryDavid Robillard4-12/+12
This is more conventional and probably best practice (since it avoids polluting the include path with non-headers), and is supported by the clang-tidy llvm-header-guard check.
2020-08-02Remove stale forward declarationsDavid Robillard6-10/+1
2020-08-02Use "using" over "typedef"David Robillard2-2/+2
2020-08-02Clean up namespace commentsDavid Robillard18-28/+29
2020-08-02Use explicit default for trivial constructorsDavid Robillard5-11/+11
2020-08-02Use default member initializationDavid Robillard8-45/+36
2020-08-02Fix implicit constructorDavid Robillard1-1/+1
2020-08-02Use consistent naming for context parametersDavid Robillard73-437/+443
2020-08-02Use std::make_sharedDavid Robillard5-10/+15
2020-08-02Remove wrappers for standard memory functionsDavid Robillard30-79/+128
2020-08-02Pass by value and use std::moveDavid Robillard1-8/+6
2020-08-02Fix uninitialized variablesDavid Robillard8-18/+23
2020-08-02Fix uninitialized membersDavid Robillard18-139/+131
2020-08-02Don't access static methods through instancesDavid Robillard4-8/+7
2020-08-02Fix incorrect strncmp lengthDavid Robillard1-1/+1
2020-08-02Use standard C++ includesDavid Robillard2-2/+2
2020-08-02Use auto with casts and allocations to remove redundancyDavid Robillard21-98/+103
2020-08-02Fix unnecessary parameter copiesDavid Robillard21-88/+90
2020-08-02Fix suppressed automatic movesDavid Robillard2-2/+2
2020-08-02Remove redundant base class initializationsDavid Robillard2-4/+3
2020-08-02Make member functions const or static where possibleDavid Robillard14-25/+24
2020-08-02Use type-appropriate math functionsDavid Robillard2-3/+3
2020-08-02Fix multiple declarations on a single lineDavid Robillard2-3/+10
2020-08-02Fix unnecessary copies in for loopsDavid Robillard6-8/+8
2020-08-02Use faster variant of std::string::findDavid Robillard1-6/+6
2020-08-02Fix include orderDavid Robillard12-16/+17
2020-08-01Use modern castsDavid Robillard64-343/+478
2020-08-01Make set_bundle_path_from_code take a function pointerDavid Robillard2-3/+4
2020-08-01Add explicit accessors to QuarkDavid Robillard13-24/+28
2020-08-01Remove superfluous semicolonsDavid Robillard1-1/+1
2020-07-18Add missing const specifiersDavid Robillard3-3/+3
2020-07-18Remove unused macrosDavid Robillard2-5/+0
2020-07-18Fix incorrect format specifiersDavid Robillard2-2/+2
2020-07-18Add missing static specifiersDavid Robillard1-1/+1
2020-02-26Fix undo and redo when using a remote serverDavid Robillard1-0/+4
2020-02-26Fix atomic bundle executionDavid Robillard4-5/+26
2020-02-26Add note about redundant arc deletion when deleting a selectionDavid Robillard1-0/+3
2020-02-26Poll for POLLPRI as wellDavid Robillard1-1/+1
I don't think this actually matters, but I'm now paranoid about poll() not waking up on input for any reason.
2020-02-26Set up serd to read directly from socket without a FILE intermediaryDavid Robillard1-19/+27
This was problematic because using fdopen() conflicts with poll(). If the FILE ends up reading more than is actually processed by serd, then poll will not fire because the socket file descriptor has been fully read, even though there is pending input in the FILE object (which is buffered). Avoid this by using a custom read function and calling recv() directly. In retrospect, this was stupid, but it seemed convenient to be able to use the handy built-in support for reading from a FILE in serd. Now, the client and server are using send() and recv() directly on the socket, as things should be. I am not sure if MSG_WAITALL is the best idea here, or if it's really important at all, but it seems like a good idea.
2019-12-08Fix use of virtual functions in destructorsDavid Robillard10-13/+19
2019-12-08Cleanup: Work around clang-tidy bugDavid Robillard1-3/+3
For some reason clang-tidy thinks that insert can modify the value of tail_block, so this triggers a null dereference warning. If that were true, it would be true with things swapped around like this as well, but it makes the warning go away at least.
2019-12-08Cleanup: Use emplace_backDavid Robillard1-1/+1
2019-12-08Cleanup: Fix potential memory leakDavid Robillard1-0/+1
2019-12-08Cleanup: Fix potential null dereferencesDavid Robillard1-7/+12
2019-12-08Cleanup: Remove potentially redundant storeDavid Robillard1-6/+4