From 6bd2c9c327aa4b4cfe431f2c729f6dd0f1a10083 Mon Sep 17 00:00:00 2001 From: David Robillard Date: Wed, 17 Jul 2024 16:44:02 -0400 Subject: Use uppercase integer literal suffixes --- .clang-tidy | 8 ++++++-- src/.clang-tidy | 1 - src/server/.clang-tidy | 1 - src/server/FrameTimer.hpp | 6 +++--- src/server/events/CreatePort.cpp | 2 +- src/server/ingen_lv2.cpp | 4 ++-- 6 files changed, 12 insertions(+), 10 deletions(-) diff --git a/.clang-tidy b/.clang-tidy index bd522e56..53dace0f 100644 --- a/.clang-tidy +++ b/.clang-tidy @@ -29,10 +29,14 @@ Checks: > -readability-identifier-length, -readability-implicit-bool-conversion, CheckOptions: - - key: modernize-use-override.AllowOverrideAndFinal - value: 'true' - key: cppcoreguidelines-explicit-virtual-functions.AllowOverrideAndFinal value: 'true' + - key: hicpp-uppercase-literal-suffix.NewSuffixes + value: 'L;U;UL;ULL' + - key: modernize-use-override.AllowOverrideAndFinal + value: 'true' + - key: readability-uppercase-literal-suffix.NewSuffixes + value: 'L;U;UL;ULL' WarningsAsErrors: '*' HeaderFilterRegex: '.*' FormatStyle: file diff --git a/src/.clang-tidy b/src/.clang-tidy index bee2fecc..8a58aa7b 100644 --- a/src/.clang-tidy +++ b/src/.clang-tidy @@ -1,6 +1,5 @@ Checks: > -*-avoid-c-arrays, - -*-uppercase-literal-suffix, -*-vararg, -android-cloexec-*, -bugprone-easily-swappable-parameters, diff --git a/src/server/.clang-tidy b/src/server/.clang-tidy index cf02c319..6990b1fe 100644 --- a/src/server/.clang-tidy +++ b/src/server/.clang-tidy @@ -2,7 +2,6 @@ Checks: > -*-avoid-c-arrays, -*-narrowing-conversions, -*-non-private-member-variables-in-classes, - -*-uppercase-literal-suffix, -*-vararg, -bugprone-branch-clone, -bugprone-parent-virtual-call, diff --git a/src/server/FrameTimer.hpp b/src/server/FrameTimer.hpp index 1f653f67..0078f99c 100644 --- a/src/server/FrameTimer.hpp +++ b/src/server/FrameTimer.hpp @@ -94,12 +94,12 @@ private: const double b; const double c; - uint64_t nper = 0u; + uint64_t nper = 0U; double e2 = 0.0; double t0 = 0.0; double t1 = 0.0; - uint64_t n0 = 0u; - uint64_t n1 = 0u; + uint64_t n0 = 0U; + uint64_t n1 = 0U; bool initialized = false; }; diff --git a/src/server/events/CreatePort.cpp b/src/server/events/CreatePort.cpp index 937842a7..4c054fd9 100644 --- a/src/server/events/CreatePort.cpp +++ b/src/server/events/CreatePort.cpp @@ -179,7 +179,7 @@ CreatePort::pre_process(PreProcessContext&) _update = _graph_port->properties(); assert(_graph_port->index() == static_cast(index_i->second.get())); - assert(_graph->num_ports_non_rt() == static_cast(old_n_ports) + 1u); + assert(_graph->num_ports_non_rt() == static_cast(old_n_ports) + 1U); assert(_ports_array->size() == _graph->num_ports_non_rt()); assert(_graph_port->index() < _ports_array->size()); return Event::pre_process_done(Status::SUCCESS); diff --git a/src/server/ingen_lv2.cpp b/src/server/ingen_lv2.cpp index f5b4e79f..424a2d7f 100644 --- a/src/server/ingen_lv2.cpp +++ b/src/server/ingen_lv2.cpp @@ -104,8 +104,8 @@ public: inline size_t ui_ring_size(SampleCount block_length) { - return std::max(static_cast(8192u), - static_cast(block_length) * 16u); + return std::max(static_cast(8192U), + static_cast(block_length) * 16U); } class LV2Driver : public Driver, public ingen::AtomSink -- cgit v1.2.1