From 784dc03a78dc338b45111ebdca45371dfaaa6fa9 Mon Sep 17 00:00:00 2001
From: David Robillard <d@drobilla.net>
Date: Tue, 23 Feb 2010 18:45:26 +0000
Subject: Fix various code issues discovered by cppcheck.

git-svn-id: http://svn.drobilla.net/lad/trunk/ingen@2484 a436a847-0d15-0410-975c-d299462d15a1
---
 src/client/HTTPClientReceiver.cpp         | 2 +-
 src/client/HTTPClientReceiver.hpp         | 2 +-
 src/client/ThreadedSigClientInterface.cpp | 2 --
 src/client/ThreadedSigClientInterface.hpp | 1 -
 4 files changed, 2 insertions(+), 5 deletions(-)

(limited to 'src/client')

diff --git a/src/client/HTTPClientReceiver.cpp b/src/client/HTTPClientReceiver.cpp
index ffa142a5..72d5a369 100644
--- a/src/client/HTTPClientReceiver.cpp
+++ b/src/client/HTTPClientReceiver.cpp
@@ -62,7 +62,7 @@ HTTPClientReceiver::~HTTPClientReceiver()
 }
 
 
-HTTPClientReceiver::Listener::Listener(HTTPClientReceiver* receiver, const std::string uri)
+HTTPClientReceiver::Listener::Listener(HTTPClientReceiver* receiver, const std::string& uri)
 	: _uri(uri)
 	, _receiver(receiver)
 {
diff --git a/src/client/HTTPClientReceiver.hpp b/src/client/HTTPClientReceiver.hpp
index 63727dcb..7df87229 100644
--- a/src/client/HTTPClientReceiver.hpp
+++ b/src/client/HTTPClientReceiver.hpp
@@ -56,7 +56,7 @@ private:
 
 	class Listener : public Raul::Thread {
 	public:
-		Listener(HTTPClientReceiver* receiver, const std::string uri);
+		Listener(HTTPClientReceiver* receiver, const std::string& uri);
 		~Listener();
 		void _run();
 	private:
diff --git a/src/client/ThreadedSigClientInterface.cpp b/src/client/ThreadedSigClientInterface.cpp
index 56eeddf6..e89d669e 100644
--- a/src/client/ThreadedSigClientInterface.cpp
+++ b/src/client/ThreadedSigClientInterface.cpp
@@ -33,8 +33,6 @@ namespace Client {
 void
 ThreadedSigClientInterface::push_sig(Closure ev)
 {
-	_attached = true;
-
 	bool success = false;
 	while (!success) {
 		success = _sigs.push(ev);
diff --git a/src/client/ThreadedSigClientInterface.hpp b/src/client/ThreadedSigClientInterface.hpp
index 6a9cffdd..028d075f 100644
--- a/src/client/ThreadedSigClientInterface.hpp
+++ b/src/client/ThreadedSigClientInterface.hpp
@@ -118,7 +118,6 @@ private:
 	Glib::Cond  _cond;
 
 	Raul::SRSWQueue<Closure> _sigs;
-	bool                     _attached;
 
 	sigc::slot<void>                                              bundle_begin_slot;
 	sigc::slot<void>                                              bundle_end_slot;
-- 
cgit v1.2.1