From e77d4fcf31bfdad0b34e184e4743b4750848472c Mon Sep 17 00:00:00 2001 From: David Robillard Date: Fri, 11 May 2012 01:29:18 +0000 Subject: Use more reasonable names for the world's interface and engine (if present). Don't require separate Configuration initialisation from World (simplify API). git-svn-id: http://svn.drobilla.net/lad/trunk/ingen@4343 a436a847-0d15-0410-975c-d299462d15a1 --- src/shared/World.cpp | 33 +++++++++++++++------------------ 1 file changed, 15 insertions(+), 18 deletions(-) (limited to 'src/shared') diff --git a/src/shared/World.cpp b/src/shared/World.cpp index 28ad1a34..1012a157 100644 --- a/src/shared/World.cpp +++ b/src/shared/World.cpp @@ -98,14 +98,12 @@ ingen_load_module(const string& name) class World::Pimpl { public: - Pimpl(Raul::Configuration* conf, - int& a_argc, + Pimpl(int& a_argc, char**& a_argv, LV2_URID_Map* map, LV2_URID_Unmap* unmap) : argc(a_argc) , argv(a_argv) - , conf(conf) , lv2_features(NULL) , rdf_world(new Sord::World()) , uri_map(new Ingen::Shared::URIMap(map, unmap)) @@ -113,6 +111,7 @@ public: , uris(new Shared::URIs(*forge, uri_map.get())) , lilv_world(lilv_world_new()) { + conf.parse(argc, argv); lv2_features = new Ingen::Shared::LV2Features(); lv2_features->add_feature(uri_map->urid_map_feature()); lv2_features->add_feature(uri_map->urid_unmap_feature()); @@ -136,7 +135,7 @@ public: serialiser.reset(); parser.reset(); - local_engine.reset(); + engine.reset(); store.reset(); modules.clear(); @@ -169,14 +168,14 @@ public: int& argc; char**& argv; - Raul::Configuration* conf; + Shared::Configuration conf; LV2Features* lv2_features; Sord::World* rdf_world; SharedPtr uri_map; Ingen::Forge* forge; SharedPtr uris; - SharedPtr engine; - SharedPtr local_engine; + SharedPtr interface; + SharedPtr engine; SharedPtr serialiser; SharedPtr parser; SharedPtr store; @@ -184,12 +183,11 @@ public: std::string jack_uuid; }; -World::World(Raul::Configuration* conf, - int& argc, +World::World(int& argc, char**& argv, LV2_URID_Map* map, LV2_URID_Unmap* unmap) - : _impl(new Pimpl(conf, argc, argv, map, unmap)) + : _impl(new Pimpl(argc, argv, map, unmap)) { } @@ -199,21 +197,20 @@ World::~World() delete _impl; } -void World::set_local_engine(SharedPtr e) { _impl->local_engine = e; } -void World::set_engine(SharedPtr e) { _impl->engine = e; } +void World::set_engine(SharedPtr e) { _impl->engine = e; } +void World::set_interface(SharedPtr i) { _impl->interface = i; } void World::set_serialiser(SharedPtr s) { _impl->serialiser = s; } void World::set_parser(SharedPtr p) { _impl->parser = p; } void World::set_store(SharedPtr s) { _impl->store = s; } -void World::set_conf(Raul::Configuration* c) { _impl->conf = c; } int& World::argc() { return _impl->argc; } char**& World::argv() { return _impl->argv; } -SharedPtr World::local_engine() { return _impl->local_engine; } -SharedPtr World::engine() { return _impl->engine; } +SharedPtr World::engine() { return _impl->engine; } +SharedPtr World::interface() { return _impl->interface; } SharedPtr World::serialiser() { return _impl->serialiser; } SharedPtr World::parser() { return _impl->parser; } SharedPtr World::store() { return _impl->store; } -Raul::Configuration* World::conf() { return _impl->conf; } +Shared::Configuration& World::conf() { return _impl->conf; } Ingen::Forge& World::forge() { return *_impl->forge; } LV2Features* World::lv2_features() { return _impl->lv2_features; } @@ -271,8 +268,8 @@ World::unload_modules() /** Get an interface for a remote engine at @a url */ SharedPtr -World::interface(const std::string& engine_url, - SharedPtr respondee) +World::new_interface(const std::string& engine_url, + SharedPtr respondee) { const string scheme = engine_url.substr(0, engine_url.find(":")); const Pimpl::InterfaceFactories::const_iterator i = _impl->interface_factories.find(scheme); -- cgit v1.2.1