From e2bbec54b3b26173284754b786310fc7d8589ecc Mon Sep 17 00:00:00 2001 From: David Robillard Date: Wed, 17 Jul 2024 10:52:37 -0400 Subject: Use empty() method instead of checking length --- src/gui/.clang-tidy | 1 - src/gui/BreadCrumbs.cpp | 4 ++-- src/server/.clang-tidy | 1 - src/server/LV2Plugin.cpp | 2 +- 4 files changed, 3 insertions(+), 5 deletions(-) (limited to 'src') diff --git a/src/gui/.clang-tidy b/src/gui/.clang-tidy index a7b2914c..4dc4facc 100644 --- a/src/gui/.clang-tidy +++ b/src/gui/.clang-tidy @@ -26,6 +26,5 @@ Checks: > -hicpp-multiway-paths-covered, -hicpp-vararg, -llvm-header-guard, - -readability-container-size-empty, -readability-convert-member-functions-to-static, InheritParentConfig: true diff --git a/src/gui/BreadCrumbs.cpp b/src/gui/BreadCrumbs.cpp index 076a259f..eb2d511b 100644 --- a/src/gui/BreadCrumbs.cpp +++ b/src/gui/BreadCrumbs.cpp @@ -92,7 +92,7 @@ BreadCrumbs::build(const raul::Path& path, // Moving to a child of the full path, append crumbs (preserve cache) string suffix = path.substr(_full_path.length()); - while (suffix.length() > 0) { + while (!suffix.empty()) { if (suffix[0] == '/') { suffix = suffix.substr(1); } @@ -135,7 +135,7 @@ BreadCrumbs::build(const raul::Path& path, raul::Path working_path("/"); string suffix = path.substr(1); - while (suffix.length() > 0) { + while (!suffix.empty()) { if (suffix[0] == '/') { suffix = suffix.substr(1); } diff --git a/src/server/.clang-tidy b/src/server/.clang-tidy index 741698de..ccc90183 100644 --- a/src/server/.clang-tidy +++ b/src/server/.clang-tidy @@ -21,6 +21,5 @@ Checks: > -llvm-header-guard, -misc-redundant-expression, -portability-simd-intrinsics, - -readability-container-size-empty, -readability-redundant-inline-specifier, InheritParentConfig: true diff --git a/src/server/LV2Plugin.cpp b/src/server/LV2Plugin.cpp index 1e88952e..ff571d0b 100644 --- a/src/server/LV2Plugin.cpp +++ b/src/server/LV2Plugin.cpp @@ -74,7 +74,7 @@ LV2Plugin::symbol() const working = working.substr(0, working.length() - 1); } - while (working.length() > 0) { + while (!working.empty()) { const size_t last_slash = working.find_last_of('/'); const std::string symbol = working.substr(last_slash+1); if ( (symbol[0] >= 'a' && symbol[0] <= 'z') -- cgit v1.2.1