From 55998092a1edfe9fd313a0a703ab4ba688e3f6ee Mon Sep 17 00:00:00 2001 From: David Robillard Date: Fri, 27 Nov 2020 17:57:46 +0100 Subject: Use appropriate std::string::find overload for characters --- .clang-tidy | 1 - src/JackDriver.cpp | 6 +++--- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/.clang-tidy b/.clang-tidy index 715ee62..df47588 100644 --- a/.clang-tidy +++ b/.clang-tidy @@ -46,7 +46,6 @@ Checks: > -llvmlibc-*, -misc-unused-parameters, -modernize-use-trailing-return-type, - -performance-faster-string-find, -performance-unnecessary-value-param, -readability-convert-member-functions-to-static, -readability-implicit-bool-conversion, diff --git a/src/JackDriver.cpp b/src/JackDriver.cpp index dfe2a1c..1432958 100644 --- a/src/JackDriver.cpp +++ b/src/JackDriver.cpp @@ -303,7 +303,7 @@ JackDriver::refresh() port = jack_port_by_name(_client, ports[i]); client1_name = ports[i]; - client1_name = client1_name.substr(0, client1_name.find(":")); + client1_name = client1_name.substr(0, client1_name.find(':')); ModuleType type = ModuleType::input_output; if (_app->conf()->get_module_split( @@ -410,8 +410,8 @@ JackDriver::port_names(const PortID& id, const std::string full_name = jack_port_name(jack_port); - module_name = full_name.substr(0, full_name.find(":")); - port_name = full_name.substr(full_name.find(":") + 1); + module_name = full_name.substr(0, full_name.find(':')); + port_name = full_name.substr(full_name.find(':') + 1); return true; } -- cgit v1.2.1