aboutsummaryrefslogtreecommitdiffstats
path: root/pugl/detail/x11.c
AgeCommit message (Collapse)AuthorFilesLines
2020-03-31X11: Don't wait for timeouts less than a millisecondDavid Robillard1-1/+1
2020-03-28Tolerate puglPostRedisplay() in configure handlersDavid Robillard1-10/+11
2020-03-17Use clearer names for pointer eventsDavid Robillard1-3/+3
These old "notify" names are a smell from X11 which is a bit strange and inconsistent here, since nearly everything is a "notification" of sorts. I think the new names here are much more clear since they are consistent with the keyboard focus events.
2020-03-16Add timer eventsDavid Robillard1-0/+139
2020-03-16X11: Dispatch a configure event before the map for child windowsDavid Robillard1-0/+9
It does not seem to be guaranteed that child windows receive a ConfigureNotify at all. Work around this by explicitly dispatching one first, so child views receive events consistently with how top level views do.
2020-03-16Factor out dispatching configure events in the drawing contextDavid Robillard1-2/+2
The updates here need to happen whenever a configure is dispatched, even outside puglDispatchEvent(). This removes the last remaining direct calls to the event callback so the common implementation can always do the right thing.
2020-03-16Only send update events when the view is visibleDavid Robillard1-1/+3
2020-03-15Unify event loop functions as puglUpdate()David Robillard1-15/+39
The previous separation between polling and dispatching was a lie, especially on MacOS where it is impossible to only poll for events without dispatching anything. Providing such an API is misleading, and problematic in various other ways. So, merge them into a single puglUpdate() function which can do the right thing on all platforms. This also adds the behaviour of actually processing all events in the given time interval, which is almost always what clients actually want to do when using a positive timeout (naively doing this before caused terrible input lag).
2020-03-15X11: Factor out flushing pending exposuresDavid Robillard1-16/+22
2020-03-15Add type and flags to worldDavid Robillard1-1/+5
Unfortunately this is an API break, but there's no reasonable way to deprecate the old function and this is required for things to work correctly. The type will be used in following commits to tick the main loop and dispatch events correctly for either case.
2020-03-15Cleanup: Add puglDispatchSimpleEvent() internal utilityDavid Robillard1-2/+1
2020-03-15Cleanup: Fix misleading variable nameDavid Robillard1-2/+2
2020-03-15Cleanup: Remove redundant PUGL_API declarationsDavid Robillard1-1/+1
2020-03-15X11: Simplify implementation slightlyDavid Robillard1-6/+2
These continue statements are not necessary since the events will not be translated anyway.
2020-03-15X11: Read from server if necessary in puglDispatchEvents()David Robillard1-3/+3
This reduces input lag. The previous approach was an over-optimization: what's important here is to keep the iteration bounded by not continually flushing, but we do want to read everything to be as up to date as possible.
2020-03-15X11: Only enter drawing context if an expose is pendingDavid Robillard1-2/+2
2020-03-15X11: Update frame immediately on ConfigureNotifyDavid Robillard1-0/+4
This fixes some jittery display issues since the frame can be used before the deferred configure actually gets dispatched.
2020-03-15X11: Factor out selection event handlingDavid Robillard1-40/+69
2020-03-15Move configure shortcut and frame update to common implementationDavid Robillard1-29/+1
2020-03-15Remove backend resize methodDavid Robillard1-5/+0
2020-03-14Add logging APIDavid Robillard1-5/+4
2020-03-13Strengthen warningsDavid Robillard1-4/+4
2020-03-09Add PuglEventClient and puglSendEvent()David Robillard1-1/+18
This event makes it possible to send an arbitrary event to a view, which is useful for many things. In particular, this method of communication with views will wake up the event loop, unlike hacks in applications that share data in some other way.
2020-03-09X11: Factor out converting PuglEventExpose to XExposeEventDavid Robillard1-16/+50
2020-03-09X11: Only send configure events if something has changedDavid Robillard1-13/+21
2020-03-09Add create, destroy, map, and unmap eventsDavid Robillard1-9/+6
These can be used to do things when a view is created or destroyed, in particular set up the GL context in a more controlled way. Map and unmap events are also added for when views are shown and hidden so application can react to this as well. Towards the deprecation of puglEnterContext() and puglLeaveContext(), which are prone to abuse. squash! Remove client event stuff
2020-03-08Cleanup: Fix some conversion warningsDavid Robillard1-6/+6
2020-03-02Strengthen ultra-strict warnings with clangDavid Robillard1-5/+5
2020-03-02Omit deprecated implementations with PUGL_DISABLE_DEPRECATEDDavid Robillard1-0/+4
2020-03-01Cleanup: Adjust some code to be more clang-format friendlyDavid Robillard1-7/+9
2020-03-01Cleanup: Fix includesDavid Robillard1-1/+2
2020-03-01Put PuglEventAny member of PuglEvent first for easy initializationDavid Robillard1-1/+1
2020-02-18Pass expose event to backend enter and leave functionsDavid Robillard1-8/+3
This is needed for clipping. Unfortunately, the puglEnterContext() and puglLeaveContext() API was not suitable for this, but this shouldn't matter in user code because it is only used for setup, and is slated for removal anyway. Instead, just call the backend functions directly in the implementation.
2020-02-18Remove immediate dispatch of exposed rectsDavid Robillard1-30/+2
This was a hack to support only exposing the rects that were explicitly exposed with puglPostRedisplayRect(), but it caused flaky drawing issues because it circumvented the deferral of exposure until the end of the loop. Instead, simply expand the pending expose to be dispatched later as usual. This means that only the union will be exposed in the end, so more area might be drawn than necessary, but this is probably good enough. If not, we will have to maintain a set of rects and be more clever about combining them.
2020-02-18Fix recursive context entryDavid Robillard1-2/+0
2020-02-11X11: Fix XMoveResizeWindow error checkZoƫ Sparks1-3/+3
In Xlib, a return value of 0 indicates an error (see "Xlib - C Language X Interface", Ch. 1, "Errors"). XMoveResizeWindow accordingly returns 1 on success, but the error check in puglSetFrame used the usual C convention, and so was backwards.
2020-02-02Only resize backend when necessaryDavid Robillard1-8/+12
This avoids resizing the backend when the window is only moved, which fixes flicker with Cairo where resizing is expensive.
2020-02-02X11: Dispatch exposures from event callbacks in the same iterationDavid Robillard1-1/+13
2020-02-02X11: Avoid calculating expose rect if view is not visibleDavid Robillard1-10/+10
2020-02-02X11: Factor out adding a pending exposureDavid Robillard1-14/+22
2019-11-21Rename "backend" headersDavid Robillard1-1/+1
Working on Vulkan clarified what has always been slightly smelly about the design and organization here: not everything that is API specific is really in a "backend" (a PuglBackend). The concrete example is puglGetProcAddress(), which only makes sense for GL and is actually implemented in the "backend" files. Arguably puglGetContext() is also such a thing. So, rename the headers so they can be the place where API-specific things go in general, which happens to include a backend most of the time. The stub is a bit of an exception to this, but whatever. The includes look tidier this way. In place of the old headers are compatibility stubs that just emit a warning and include the new version, which will be maintained for a while.
2019-11-18Cleanup: Remove unnecessary includesDavid Robillard1-1/+0
2019-11-17X11: Don't select on server socket if events are already queuedosch1-1/+3
2019-11-17X11: Support pasting (almost) arbitrarily long textDavid Robillard1-1/+1
This is a bit ridiculous, but using a "probably big enough" value seems to be what everyone does. This particular value is the one used by Gtk.
2019-11-17X11: Don't send expose events to invisible windowsDavid Robillard1-1/+3
2019-11-17X11: Track visibility via system eventsDavid Robillard1-3/+8
This ensure that visibility is properly updated when a window is made visible or invisible by the user or window system. Unfortunately it does not seem to propagate automatically to child windows, but this is at least better than the previous situation, and good enough for most cases.
2019-11-09Fix various clang-tidy warningsDavid Robillard1-1/+1
2019-11-03Remove redisplay flag and add puglPostRedisplayRect()David Robillard1-19/+22
2019-11-03X11: Only merge expose events if they intersectDavid Robillard1-13/+45
Towards actual fine-grained exposure. This uses the previous behaviour if expose events intersect to reduce redundant drawing, but dispatches expose events immediately (after flushing and pending configure events) if they don't to support partial redraws.
2019-11-03Add puglGetNativeWorld()David Robillard1-0/+6