summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDavid Robillard <d@drobilla.net>2022-07-20 11:06:22 -0400
committerDavid Robillard <d@drobilla.net>2022-07-20 16:24:23 -0400
commitf58a928dc15a0b8fe58d5a242b071f67e14c08dd (patch)
tree93c0e26187f4e4a43cf1b0c7db3f8f6fa7c09a3c
parente883d87e43b06b54a810413d0a728ace1e9c26a0 (diff)
downloadraul-f58a928dc15a0b8fe58d5a242b071f67e14c08dd.tar.gz
raul-f58a928dc15a0b8fe58d5a242b071f67e14c08dd.tar.bz2
raul-f58a928dc15a0b8fe58d5a242b071f67e14c08dd.zip
Remove redundant inheritance from Noncopyable
All copy/move methods are explicitly specified by these classes, so inheriting from Noncopyable didn't do anything useful. It should probably be removed as non-idiomatic.
-rw-r--r--include/raul/Maid.hpp3
-rw-r--r--include/raul/RingBuffer.hpp4
-rw-r--r--include/raul/Socket.hpp4
3 files changed, 3 insertions, 8 deletions
diff --git a/include/raul/Maid.hpp b/include/raul/Maid.hpp
index 31a7331..2ca6fad 100644
--- a/include/raul/Maid.hpp
+++ b/include/raul/Maid.hpp
@@ -5,7 +5,6 @@
#define RAUL_MAID_HPP
#include "raul/Deletable.hpp"
-#include "raul/Noncopyable.hpp"
#include <atomic>
#include <memory>
@@ -24,7 +23,7 @@ namespace raul {
@ingroup raul
*/
-class Maid : public Noncopyable
+class Maid
{
public:
/// An object that can be disposed via Maid::dispose()
diff --git a/include/raul/RingBuffer.hpp b/include/raul/RingBuffer.hpp
index acb4115..04f7cd7 100644
--- a/include/raul/RingBuffer.hpp
+++ b/include/raul/RingBuffer.hpp
@@ -4,8 +4,6 @@
#ifndef RAUL_RINGBUFFER_HPP
#define RAUL_RINGBUFFER_HPP
-#include "raul/Noncopyable.hpp"
-
#include <atomic>
#include <cassert>
#include <cstdint>
@@ -22,7 +20,7 @@ namespace raul {
@ingroup raul
*/
-class RingBuffer : public Noncopyable
+class RingBuffer
{
public:
/**
diff --git a/include/raul/Socket.hpp b/include/raul/Socket.hpp
index 28a3c3a..4a66d0b 100644
--- a/include/raul/Socket.hpp
+++ b/include/raul/Socket.hpp
@@ -4,8 +4,6 @@
#ifndef RAUL_SOCKET_HPP
#define RAUL_SOCKET_HPP
-#include "raul/Noncopyable.hpp"
-
#include <netdb.h>
#include <sys/socket.h>
#include <sys/un.h>
@@ -24,7 +22,7 @@ namespace raul {
@ingroup raul
*/
-class Socket : public raul::Noncopyable
+class Socket
{
public:
enum class Type { UNIX, TCP };