diff options
author | David Robillard <d@drobilla.net> | 2016-07-07 23:50:39 -0400 |
---|---|---|
committer | David Robillard <d@drobilla.net> | 2018-12-30 17:56:22 -0500 |
commit | 86681fbf464d47f8962238d472a7d521643d5dd6 (patch) | |
tree | c104bd7552c5c5373af092c5d043001e72aa3efb /src | |
parent | cedc9530cee8518f92d949984d173be1e707e31e (diff) | |
download | serd-86681fbf464d47f8962238d472a7d521643d5dd6.tar.gz serd-86681fbf464d47f8962238d472a7d521643d5dd6.tar.bz2 serd-86681fbf464d47f8962238d472a7d521643d5dd6.zip |
Make serd_strtod API const-correct
This is an API breakage, but a minor one (particularly since NULL is
allowed) that avoids the flaw in the C API.
Diffstat (limited to 'src')
-rw-r--r-- | src/reader.c | 2 | ||||
-rw-r--r-- | src/reader.h | 2 | ||||
-rw-r--r-- | src/serd_internal.h | 2 | ||||
-rw-r--r-- | src/string.c | 6 |
4 files changed, 6 insertions, 6 deletions
diff --git a/src/reader.c b/src/reader.c index 0eb06c88..37c4719c 100644 --- a/src/reader.c +++ b/src/reader.c @@ -79,7 +79,7 @@ Ref push_node_padded(SerdReader* reader, size_t maxlen, SerdType type, const char* str, size_t n_bytes) { - char* mem = (char*)serd_stack_push_aligned( + void* mem = serd_stack_push_aligned( &reader->stack, sizeof(SerdNode) + maxlen + 1, sizeof(SerdNode)); SerdNode* const node = (SerdNode*)mem; diff --git a/src/reader.h b/src/reader.h index 6e1a24d7..f3ddde0a 100644 --- a/src/reader.h +++ b/src/reader.h @@ -68,7 +68,7 @@ static inline SerdStatus push_byte(SerdReader* reader, Ref ref, const uint8_t c) { SERD_STACK_ASSERT_TOP(reader, ref); - char* const s = serd_stack_push(&reader->stack, 1); + char* const s = (char*)serd_stack_push(&reader->stack, 1); SerdNode* const node = (SerdNode*)(reader->stack.buf + ref); ++node->n_bytes; *(s - 1) = c; diff --git a/src/serd_internal.h b/src/serd_internal.h index cccb321b..b4df45fb 100644 --- a/src/serd_internal.h +++ b/src/serd_internal.h @@ -195,7 +195,7 @@ serd_stack_free(SerdStack* stack) stack->size = 0; } -static inline char* +static inline void* serd_stack_push(SerdStack* stack, size_t n_bytes) { const size_t new_size = stack->size + n_bytes; diff --git a/src/string.c b/src/string.c index a1d46507..01ed25a0 100644 --- a/src/string.c +++ b/src/string.c @@ -100,7 +100,7 @@ read_sign(const char** sptr) } double -serd_strtod(const char* str, char** endptr) +serd_strtod(const char* str, size_t* end) { double result = 0.0; @@ -136,8 +136,8 @@ serd_strtod(const char* str, char** endptr) result *= pow(10, expt * expt_sign); } - if (endptr) { - *endptr = (char*)s; + if (end) { + *end = s - str; } return result * sign; |