From 5947cac55a98140859b7a5e7de357a1d45bccd43 Mon Sep 17 00:00:00 2001 From: David Robillard Date: Sun, 23 Oct 2022 21:48:47 -0400 Subject: Fix "suspicious" string comparison This is beyond silly. --- src/.clang-tidy | 1 - src/uri.c | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/src/.clang-tidy b/src/.clang-tidy index 3c8a24d7..331ec702 100644 --- a/src/.clang-tidy +++ b/src/.clang-tidy @@ -4,7 +4,6 @@ Checks: > -*-magic-numbers, -bugprone-easily-swappable-parameters, - -bugprone-suspicious-string-compare, -cert-err33-c, -clang-analyzer-security.insecureAPI.DeprecatedOrUnsafeBufferHandling, -concurrency-mt-unsafe, diff --git a/src/uri.c b/src/uri.c index 55e8db47..151f63e3 100644 --- a/src/uri.c +++ b/src/uri.c @@ -17,7 +17,7 @@ serd_uri_to_path(const uint8_t* uri) { const uint8_t* path = uri; if (!is_windows_path(uri) && serd_uri_string_has_scheme(uri)) { - if (strncmp((const char*)uri, "file:", 5)) { + if (!!strncmp((const char*)uri, "file:", 5)) { fprintf(stderr, "Non-file URI `%s'\n", uri); return NULL; } -- cgit v1.2.1