From eecc32d625fb418ea48cd69302d0791a96a25655 Mon Sep 17 00:00:00 2001 From: David Robillard Date: Mon, 3 Apr 2023 09:00:39 -0400 Subject: Simplify stdout capturing code This is slightly less excruciatingly slow on Windows, sometimes, maybe. --- test/run_suite.py | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/test/run_suite.py b/test/run_suite.py index 3f935fcf..2e93502f 100755 --- a/test/run_suite.py +++ b/test/run_suite.py @@ -43,11 +43,9 @@ def run_eval_test(base_uri, command, in_path, good_path, out_path): syntax = util.syntax_from_path(out_path) command = command + ["-o", syntax, in_path, base_uri] - proc = subprocess.run( - command, check=True, encoding="utf-8", stderr=DEVNULL, stdout=PIPE - ) + with subprocess.Popen(command, stdout=PIPE, encoding="utf-8") as proc: + out = list(proc.stdout) - out = [line + "\n" for line in proc.stdout.split("\n")][:-1] with open(good_path, "r", encoding="utf-8") as good: return util.lines_equal(list(good), out, good_path, out_path) -- cgit v1.2.1