From 07eb022d816bcefdc46f11e608e4a79de164eeb0 Mon Sep 17 00:00:00 2001
From: David Robillard <d@drobilla.net>
Date: Wed, 15 Jul 2020 20:00:37 +0200
Subject: Fix Wunused-parameter warnings

---
 src/gtk2_in_qt5.cpp | 18 +++++++-----------
 src/host.c          |  2 ++
 src/qt5_in_gtk.cpp  |  8 ++++----
 src/x11_in_gtk2.c   |  8 ++++++++
 src/x11_in_gtk3.c   |  6 ++++++
 src/x11_in_qt5.cpp  |  6 +++---
 wscript             |  2 --
 7 files changed, 30 insertions(+), 20 deletions(-)

diff --git a/src/gtk2_in_qt5.cpp b/src/gtk2_in_qt5.cpp
index 50b9012..1b2a429 100644
--- a/src/gtk2_in_qt5.cpp
+++ b/src/gtk2_in_qt5.cpp
@@ -37,18 +37,14 @@ struct _SuilGtk2InQt5Wrapper {
 };
 
 static void
-on_size_request(GtkWidget*      widget,
-                GtkRequisition* requisition,
-                gpointer        user_data)
+on_size_request(GtkWidget*, GtkRequisition* requisition, gpointer user_data)
 {
 	QWidget* const wrap = (QWidget*)user_data;
 	wrap->setMinimumSize(requisition->width, requisition->height);
 }
 
 static void
-on_size_allocate(GtkWidget*    widget,
-                 GdkRectangle* allocation,
-                 gpointer      user_data)
+on_size_allocate(GtkWidget*, GdkRectangle* allocation, gpointer user_data)
 {
 	QWidget* const wrap = (QWidget*)user_data;
 	wrap->resize(allocation->width, allocation->height);
@@ -120,11 +116,11 @@ wrapper_wrap(SuilWrapper*  wrapper,
 
 SUIL_LIB_EXPORT
 SuilWrapper*
-suil_wrapper_new(SuilHost*      host,
-                 const char*    host_type_uri,
-                 const char*    ui_type_uri,
-                 LV2_Feature*** features,
-                 unsigned       n_features)
+suil_wrapper_new(SuilHost* host,
+                 const char*,
+                 const char*,
+                 LV2_Feature***,
+                 unsigned)
 {
 	/* We have to open libgtk here, so Gtk type symbols are present and will be
 	   found by the introspection stuff.  This is required at least to make
diff --git a/src/host.c b/src/host.c
index f64f9c5..0eabb5a 100644
--- a/src/host.c
+++ b/src/host.c
@@ -81,6 +81,8 @@ SUIL_API
 void
 suil_init(int* argc, char*** argv, SuilArg key, ...)
 {
+	(void)key;
+
 	suil_argc = argc ? *argc : 0;
 	suil_argv = argv ? *argv : NULL;
 
diff --git a/src/qt5_in_gtk.cpp b/src/qt5_in_gtk.cpp
index 70a14c0..ab682c6 100644
--- a/src/qt5_in_gtk.cpp
+++ b/src/qt5_in_gtk.cpp
@@ -102,7 +102,7 @@ suil_qt_wrapper_init(SuilQtWrapper* self)
 }
 
 static void
-suil_qt_wrapper_realize(GtkWidget* w, gpointer data)
+suil_qt_wrapper_realize(GtkWidget* w, gpointer)
 {
 	SuilQtWrapper* const wrap = SUIL_QT_WRAPPER(w);
 	GtkSocket* const     s    = GTK_SOCKET(w);
@@ -183,9 +183,9 @@ wrapper_free(SuilWrapper* wrapper)
 
 SUIL_LIB_EXPORT
 SuilWrapper*
-suil_wrapper_new(SuilHost*      host,
-                 const char*    host_type_uri,
-                 const char*    ui_type_uri,
+suil_wrapper_new(SuilHost*,
+                 const char*,
+                 const char*,
                  LV2_Feature*** features,
                  unsigned       n_features)
 {
diff --git a/src/x11_in_gtk2.c b/src/x11_in_gtk2.c
index 3041b07..742a0b6 100644
--- a/src/x11_in_gtk2.c
+++ b/src/x11_in_gtk2.c
@@ -113,6 +113,8 @@ get_parent_window(Display* display, Window child)
 static gboolean
 on_plug_removed(GtkSocket* sock, gpointer data)
 {
+	(void)data;
+
 	SuilX11Wrapper* const self = SUIL_X11_WRAPPER(sock);
 
 	if (self->idle_id) {
@@ -368,6 +370,8 @@ suil_x11_on_size_allocate(GtkWidget*     widget,
 static void
 suil_x11_on_map_event(GtkWidget* widget, GdkEvent* event)
 {
+	(void)event;
+
 	SuilX11Wrapper* const self = SUIL_X11_WRAPPER(widget);
 
 	/* Reset the size request to the minimum sizes.  This is called after the
@@ -524,6 +528,10 @@ suil_wrapper_new(SuilHost*      host,
                  LV2_Feature*** features,
                  unsigned       n_features)
 {
+	(void)host;
+	(void)host_type_uri;
+	(void)ui_type_uri;
+
 	SuilWrapper* wrapper = (SuilWrapper*)calloc(1, sizeof(SuilWrapper));
 	wrapper->wrap = wrapper_wrap;
 	wrapper->free = wrapper_free;
diff --git a/src/x11_in_gtk3.c b/src/x11_in_gtk3.c
index 7faab02..6ec1994 100644
--- a/src/x11_in_gtk3.c
+++ b/src/x11_in_gtk3.c
@@ -85,6 +85,8 @@ x_window_is_valid(SuilX11Wrapper* socket)
 static gboolean
 on_plug_removed(GtkSocket* sock, gpointer data)
 {
+	(void)data;
+
 	SuilX11Wrapper* const self = SUIL_X11_WRAPPER(sock);
 
 	if (self->idle_id) {
@@ -431,6 +433,10 @@ suil_wrapper_new(SuilHost*      host,
                  LV2_Feature*** features,
                  unsigned       n_features)
 {
+	(void)host;
+	(void)host_type_uri;
+	(void)ui_type_uri;
+
 	SuilWrapper* wrapper = (SuilWrapper*)calloc(1, sizeof(SuilWrapper));
 	wrapper->wrap = wrapper_wrap;
 	wrapper->free = wrapper_free;
diff --git a/src/x11_in_qt5.cpp b/src/x11_in_qt5.cpp
index 2d5333f..c6c551f 100644
--- a/src/x11_in_qt5.cpp
+++ b/src/x11_in_qt5.cpp
@@ -198,9 +198,9 @@ wrapper_resize(LV2UI_Feature_Handle handle, int width, int height)
 
 SUIL_LIB_EXPORT
 SuilWrapper*
-suil_wrapper_new(SuilHost*      host,
-                 const char*    host_type_uri,
-                 const char*    ui_type_uri,
+suil_wrapper_new(SuilHost*,
+                 const char*,
+                 const char*,
                  LV2_Feature*** features,
                  unsigned       n_features)
 {
diff --git a/wscript b/wscript
index e70db4e..f789ef1 100644
--- a/wscript
+++ b/wscript
@@ -59,13 +59,11 @@ def configure(conf):
         autowaf.add_compiler_flags(conf.env, '*', {
             'gcc': [
                 '-Wno-padded',
-                '-Wno-unused-parameter',
             ],
             'clang': [
                 '-Wno-cast-qual',
                 '-Wno-disabled-macro-expansion',
                 '-Wno-padded',
-                '-Wno-unused-parameter',
             ]
         })
 
-- 
cgit v1.2.1