From 0945afa159d0da327d4da8d2c4e7d345d308cd97 Mon Sep 17 00:00:00 2001 From: David Robillard Date: Fri, 2 Jul 2021 13:56:21 -0400 Subject: Avoid allegedly "suspicious" string comparisons I guess these are suspicious if you've never seen C before? --- benchmark/.clang-tidy | 1 - benchmark/dict_bench.c | 4 ++-- 2 files changed, 2 insertions(+), 3 deletions(-) (limited to 'benchmark') diff --git a/benchmark/.clang-tidy b/benchmark/.clang-tidy index 2c16e13..038fecc 100644 --- a/benchmark/.clang-tidy +++ b/benchmark/.clang-tidy @@ -4,7 +4,6 @@ Checks: > -*-uppercase-literal-suffix, -android-cloexec-fopen, -bugprone-reserved-identifier, - -bugprone-suspicious-string-compare, -cert-dcl37-c, -cert-dcl51-cpp, -clang-analyzer-security.insecureAPI.DeprecatedOrUnsafeBufferHandling, diff --git a/benchmark/dict_bench.c b/benchmark/dict_bench.c index 4a77257..90b0abc 100644 --- a/benchmark/dict_bench.c +++ b/benchmark/dict_bench.c @@ -165,7 +165,7 @@ main(int argc, char** argv) for (size_t i = 0; i < n; ++i) { const size_t index = lcg64(seed + i) % n; char* match = (char*)g_hash_table_lookup(hash, strings[index]); - if (strcmp(match, strings[index])) { + if (!!strcmp(match, strings[index])) { return test_fail("Bad match for `%s'\n", strings[index]); } } @@ -181,7 +181,7 @@ main(int argc, char** argv) return test_fail("Hash: Failed to find `%s'\n", strings[index]); } - if (strcmp((const char*)match->buf, strings[index])) { + if (!!strcmp((const char*)match->buf, strings[index])) { return test_fail("Hash: Bad match %p for `%s': `%s'\n", (const void*)match, strings[index], -- cgit v1.2.1