From 841c766d86dc35ab37c4fef8ec866d06c41bc383 Mon Sep 17 00:00:00 2001 From: David Robillard Date: Thu, 31 Dec 2020 14:56:07 +0100 Subject: Avoid "else" after "return" --- benchmark/tree_bench.c | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) (limited to 'benchmark') diff --git a/benchmark/tree_bench.c b/benchmark/tree_bench.c index f87af78..b458bb1 100644 --- a/benchmark/tree_bench.c +++ b/benchmark/tree_bench.c @@ -42,10 +42,10 @@ unique_rand(size_t i) static const size_t prime = 4294967291; if (i >= prime) { return i; // Values >= prime are mapped to themselves - } else { - const size_t residue = ((uint64_t)i * i) % prime; - return (i <= prime / 2) ? residue : prime - residue; } + + const size_t residue = ((uint64_t)i * i) % prime; + return (i <= prime / 2) ? residue : prime - residue; } static int @@ -53,14 +53,18 @@ int_cmp(const void* a, const void* b, const void* ZIX_UNUSED(user_data)) { const intptr_t ia = (intptr_t)a; const intptr_t ib = (intptr_t)b; + // note the (ia - ib) trick here would overflow + if (ia == ib) { return 0; - } else if (ia < ib) { + } + + if (ia < ib) { return -1; - } else { - return 1; } + + return 1; } static int -- cgit v1.2.1