diff options
| author | Stefan Kost <ensonic@users.sourceforge.net> | 2008-03-20 15:54:23 +0000 |
|---|---|---|
| committer | Stefan Kost <ensonic@users.sourceforge.net> | 2008-03-20 15:54:23 +0000 |
| commit | 6ad41986af602c84943ce3aa5fa373047dcd9114 (patch) | |
| tree | e35be419206e6615d23059be779252526953609c | |
| parent | 7a1019a2b310cd9f91fdcb14c662291d707d1820 (diff) | |
| download | gst-plugins-bad-6ad41986af602c84943ce3aa5fa373047dcd9114.tar.gz gst-plugins-bad-6ad41986af602c84943ce3aa5fa373047dcd9114.tar.bz2 gst-plugins-bad-6ad41986af602c84943ce3aa5fa373047dcd9114.zip | |
ext/ladspa/: Add some thoughts and FIXME's.
Original commit message from CVS:
* ext/ladspa/gstladspa.c:
* ext/ladspa/gstsignalprocessor.c:
Add some thoughts and FIXME's.
| -rw-r--r-- | ChangeLog | 6 | ||||
| -rw-r--r-- | ext/ladspa/gstladspa.c | 9 | ||||
| -rw-r--r-- | ext/ladspa/gstsignalprocessor.c | 4 |
3 files changed, 18 insertions, 1 deletions
@@ -1,5 +1,11 @@ 2008-03-20 Stefan Kost <ensonic@users.sf.net> + * ext/ladspa/gstladspa.c: + * ext/ladspa/gstsignalprocessor.c: + Add some thoughts and FIXME's. + +2008-03-20 Stefan Kost <ensonic@users.sf.net> + * gst/bayer/gstbayer2rgb.c: Include stdlib.h for abs. diff --git a/ext/ladspa/gstladspa.c b/ext/ladspa/gstladspa.c index 469c64eb..54e3eaf3 100644 --- a/ext/ladspa/gstladspa.c +++ b/ext/ladspa/gstladspa.c @@ -89,7 +89,16 @@ gst_ladspa_base_init (gpointer g_class) if (LADSPA_IS_PORT_AUDIO (p)) { gchar *name = g_strdup ((gchar *) desc->PortNames[j]); + /* FIXME: group stereo pairs into a stereo pad + * ladspa-fx have "XXX (Left)" and "XXX (Right)" + * where XXX={In,Input,Out,Output} + */ + GST_DEBUG ("LADSPA port name: \"%s\"", name); + /* replaces all spaces with underscores, and then remaining special chars + * with '-' + * FIXME: why, pads can have any name + */ g_strdelimit (name, " ", '_'); g_strcanon (name, G_CSET_A_2_Z G_CSET_a_2_z G_CSET_DIGITS "_-><=", '-'); GST_DEBUG ("GStreamer pad name: \"%s\"", name); diff --git a/ext/ladspa/gstsignalprocessor.c b/ext/ladspa/gstsignalprocessor.c index 364f4fec..9cc5af24 100644 --- a/ext/ladspa/gstsignalprocessor.c +++ b/ext/ladspa/gstsignalprocessor.c @@ -35,7 +35,7 @@ GST_DEBUG_CATEGORY_STATIC (gst_signal_processor_debug); #define GST_CAT_DEFAULT gst_signal_processor_debug - +/* FIXME: this is mono only */ static GstStaticCaps template_caps = GST_STATIC_CAPS (GST_AUDIO_FLOAT_STANDARD_PAD_TEMPLATE_CAPS); @@ -71,6 +71,8 @@ gst_signal_processor_pad_template_get_type (void) return type; } +/* FIXME: better allow the caller to pass on the template, right now this can + * only create mono pads */ void gst_signal_processor_class_add_pad_template (GstSignalProcessorClass * klass, const gchar * name, GstPadDirection direction, guint index) |