summaryrefslogtreecommitdiffstats
path: root/ext/metadata/metadataexif.c
diff options
context:
space:
mode:
authorStefan Kost <ensonic@users.sf.net>2009-07-20 16:19:40 +0300
committerStefan Kost <ensonic@users.sf.net>2009-07-20 16:42:43 +0300
commit51e022d2883c91feae664dbbba6d03ca81b95865 (patch)
treee9f2897732e5ff41b2e6714abed6e1b3c85f08ae /ext/metadata/metadataexif.c
parentcae6b621aaa64bbfdda102e8295b9035e0c42fa8 (diff)
downloadgst-plugins-bad-51e022d2883c91feae664dbbba6d03ca81b95865.tar.gz
gst-plugins-bad-51e022d2883c91feae664dbbba6d03ca81b95865.tar.bz2
gst-plugins-bad-51e022d2883c91feae664dbbba6d03ca81b95865.zip
metadata: don't dereference the pointer before the validity check
Diffstat (limited to 'ext/metadata/metadataexif.c')
-rw-r--r--ext/metadata/metadataexif.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/ext/metadata/metadataexif.c b/ext/metadata/metadataexif.c
index cbdbf30d..1fb97d58 100644
--- a/ext/metadata/metadataexif.c
+++ b/ext/metadata/metadataexif.c
@@ -556,11 +556,13 @@ metadataparse_exif_content_foreach_entry_func (ExifEntry * entry,
MEUserData *meudata = (MEUserData *) user_data;
GType type = G_TYPE_NONE;
ExifByteOrder byte_order;
- const gchar *tag = metadataparse_exif_get_tag_from_exif (entry->tag, &type);
+ const gchar *tag;
/* We need the byte order */
if (!entry || !entry->parent || !entry->parent->parent)
return;
+
+ tag = metadataparse_exif_get_tag_from_exif (entry->tag, &type);
byte_order = exif_data_get_byte_order (entry->parent->parent);
if (metadataparse_handle_unit_tags (entry, meudata, byte_order))