Make build without warnings with debugging disabled

7 files changed, 21 insertions, 25 deletions

diff --git a/ext/apexsink/gstapexsink.c b/ext/apexsink/gstapexsink.c
index 425308d4..69f34bcb 100644
--- a/ext/apexsink/gstapexsink.c
+++ b/ext/apexsink/gstapexsink.c
@@ -523,9 +523,7 @@ gst_apexsink_write (GstAudioSink * asink, gpointer data, guint length)
 static gboolean
 gst_apexsink_unprepare (GstAudioSink * asink)
 {
-  GstApExSink *apexsink = (GstApExSink *) asink;
-
-  GST_INFO_OBJECT (apexsink, "UNPREPARE");
+  GST_INFO_OBJECT (asink, "UNPREPARE");
 
   return TRUE;
 }
@@ -534,9 +532,7 @@ gst_apexsink_unprepare (GstAudioSink * asink)
 static guint
 gst_apexsink_delay (GstAudioSink * asink)
 {
-  GstApExSink *apexsink = (GstApExSink *) asink;
-
-  GST_INFO_OBJECT (apexsink, "DELAY");
+  GST_LOG_OBJECT (asink, "DELAY");
 
   return 0;
 }
diff --git a/ext/directfb/dfbvideosink.c b/ext/directfb/dfbvideosink.c
index a6450a06..f48864d6 100644
--- a/ext/directfb/dfbvideosink.c
+++ b/ext/directfb/dfbvideosink.c
@@ -144,6 +144,7 @@ static void gst_dfbvideosink_surface_destroy (GstDfbVideoSink * dfbvideosink,
 static GstVideoSinkClass *parent_class = NULL;
 static GstBufferClass *surface_parent_class = NULL;
 
+#ifndef GST_DISABLE_GST_DEBUG
 static const char *
 gst_dfbvideosink_get_format_name (DFBSurfacePixelFormat format)
 {
@@ -192,6 +193,7 @@ gst_dfbvideosink_get_format_name (DFBSurfacePixelFormat format)
       return "UNKNOWN";
   }
 }
+#endif /* GST_DISABLE_GST_DEBUG */
 
 /* Creates miniobject and our internal surface */
 static GstDfbSurface *
@@ -1945,7 +1947,7 @@ gst_dfbvideosink_navigation_send_event (GstNavigation * navigation,
   GstDfbVideoSink *dfbvideosink = GST_DFBVIDEOSINK (navigation);
   GstEvent *event;
   GstVideoRectangle src, dst, result;
-  double x, y;
+  double x, y, old_x, old_y;
   GstPad *pad = NULL;
 
   src.w = GST_VIDEO_SINK_WIDTH (dfbvideosink);
@@ -1959,8 +1961,8 @@ gst_dfbvideosink_navigation_send_event (GstNavigation * navigation,
   /* Our coordinates can be wrong here if we centered the video */
 
   /* Converting pointer coordinates to the non scaled geometry */
-  if (gst_structure_get_double (structure, "pointer_x", &x)) {
-    double old_x = x;
+  if (gst_structure_get_double (structure, "pointer_x", &old_x)) {
+    x = old_x;
 
     if (x >= result.x && x <= (result.x + result.w)) {
       x -= result.x;
@@ -1973,8 +1975,8 @@ gst_dfbvideosink_navigation_send_event (GstNavigation * navigation,
         "coordinate from %f to %f", old_x, x);
     gst_structure_set (structure, "pointer_x", G_TYPE_DOUBLE, x, NULL);
   }
-  if (gst_structure_get_double (structure, "pointer_y", &y)) {
-    double old_y = y;
+  if (gst_structure_get_double (structure, "pointer_y", &old_y)) {
+    y = old_y;
 
     if (y >= result.y && y <= (result.y + result.h)) {
       y -= result.y;
diff --git a/ext/libmms/gstmms.c b/ext/libmms/gstmms.c
index 33a1a7d2..5ccbb732 100644
--- a/ext/libmms/gstmms.c
+++ b/ext/libmms/gstmms.c
@@ -240,23 +240,22 @@ gst_mms_prepare_seek_segment (GstBaseSrc * src, GstEvent * event,
   GstSeekFlags flags;
   GstFormat seek_format;
   gdouble rate;
-  GstMMS *mmssrc = GST_MMS (src);
 
   gst_event_parse_seek (event, &rate, &seek_format, &flags,
       &cur_type, &cur, &stop_type, &stop);
 
   if (seek_format != GST_FORMAT_BYTES && seek_format != GST_FORMAT_TIME) {
-    GST_LOG_OBJECT (mmssrc, "Only byte or time seeking is supported");
+    GST_LOG_OBJECT (src, "Only byte or time seeking is supported");
     return FALSE;
   }
 
   if (stop_type != GST_SEEK_TYPE_NONE) {
-    GST_LOG_OBJECT (mmssrc, "Stop seeking not supported");
+    GST_LOG_OBJECT (src, "Stop seeking not supported");
     return FALSE;
   }
 
   if (cur_type != GST_SEEK_TYPE_NONE && cur_type != GST_SEEK_TYPE_SET) {
-    GST_LOG_OBJECT (mmssrc, "Only absolute seeking is supported");
+    GST_LOG_OBJECT (src, "Only absolute seeking is supported");
     return FALSE;
   }
 
diff --git a/ext/metadata/metadataexif.c b/ext/metadata/metadataexif.c
index 73cb275b..58d83e2d 100644
--- a/ext/metadata/metadataexif.c
+++ b/ext/metadata/metadataexif.c
@@ -739,6 +739,7 @@ metadataparse_exif_content_foreach_entry_func (ExifEntry * entry,
 
 done:
   {
+#ifndef GST_DISABLE_GST_DEBUG
     char buf[2048];
     GST_LOG ("\n    Entry %p: %s (%s)\n"
         "      Size, Comps: %d, %d\n"
@@ -752,6 +753,7 @@ done:
         (int) (entry->components),
         exif_entry_get_value (entry, buf, sizeof (buf)),
         exif_tag_get_title (entry->tag), exif_tag_get_description (entry->tag));
+#endif
   }
   return;
 
diff --git a/ext/mythtv/gstmythtvsrc.c b/ext/mythtv/gstmythtvsrc.c
index 4d1ddb53..6a11f2d4 100644
--- a/ext/mythtv/gstmythtvsrc.c
+++ b/ext/mythtv/gstmythtvsrc.c
@@ -1017,9 +1017,7 @@ gst_mythtv_src_uri_handler_init (gpointer g_iface, gpointer iface_data)
 }
 
 void
-size_header_handler (void *userdata, const char *value)
+size_header_handler (void *src, const char *value)
 {
-  GstMythtvSrc *src = GST_MYTHTV_SRC (userdata);
-
   GST_DEBUG_OBJECT (src, "content size = %lld bytes", src->content_size);
 }
diff --git a/ext/resindvd/resindvdsrc.c b/ext/resindvd/resindvdsrc.c
index 122f2b67..7b44bf9c 100644
--- a/ext/resindvd/resindvdsrc.c
+++ b/ext/resindvd/resindvdsrc.c
@@ -1069,9 +1069,8 @@ rsn_dvdsrc_step (resinDvdSrc * src, gboolean have_dvd_lock)
       break;
     }
     case DVDNAV_HIGHLIGHT:{
-      dvdnav_highlight_event_t *event = (dvdnav_highlight_event_t *) data;
       GST_DEBUG_OBJECT (src, "highlight change event, button %d",
-          event->buttonN);
+          ((dvdnav_highlight_event_t *) data)->buttonN);
       rsn_dvdsrc_update_highlight (src);
       break;
     }
diff --git a/ext/sdl/sdlvideosink.c b/ext/sdl/sdlvideosink.c
index ef8147ea..85f26534 100644
--- a/ext/sdl/sdlvideosink.c
+++ b/ext/sdl/sdlvideosink.c
@@ -948,7 +948,7 @@ gst_sdlvideosink_navigation_send_event (GstNavigation * navigation,
   GstSDLVideoSink *sdlvideosink = GST_SDLVIDEOSINK (navigation);
   GstEvent *event;
   GstVideoRectangle src, dst, result;
-  double x, y;
+  double x, y, old_x, old_y;
   GstPad *pad = NULL;
 
   src.w = GST_VIDEO_SINK_WIDTH (sdlvideosink);
@@ -962,8 +962,8 @@ gst_sdlvideosink_navigation_send_event (GstNavigation * navigation,
   /* Our coordinates can be wrong here if we centered the video */
 
   /* Converting pointer coordinates to the non scaled geometry */
-  if (gst_structure_get_double (structure, "pointer_x", &x)) {
-    double old_x = x;
+  if (gst_structure_get_double (structure, "pointer_x", &old_x)) {
+    x = old_x;
 
     if (x >= result.x && x <= (result.x + result.w)) {
       x -= result.x;
@@ -976,8 +976,8 @@ gst_sdlvideosink_navigation_send_event (GstNavigation * navigation,
         "coordinate from %f to %f", old_x, x);
     gst_structure_set (structure, "pointer_x", G_TYPE_DOUBLE, x, NULL);
   }
-  if (gst_structure_get_double (structure, "pointer_y", &y)) {
-    double old_y = y;
+  if (gst_structure_get_double (structure, "pointer_y", &old_y)) {
+    y = old_y;
 
     if (y >= result.y && y <= (result.y + result.h)) {
       y -= result.y;