summaryrefslogtreecommitdiffstats
path: root/gst/festival/gstfestival.c
diff options
context:
space:
mode:
authorDavid Schleef <ds@schleef.org>2003-07-24 08:49:43 +0000
committerDavid Schleef <ds@schleef.org>2003-07-24 08:49:43 +0000
commita962c0f40c1bf71b44a67f898a35122f158b6b25 (patch)
tree591c4255a1b28c76e1a0331e6648bb3f6585fad9 /gst/festival/gstfestival.c
parenta287b1e4420e0d89ca83e1343acbbae74c8aea9b (diff)
downloadgst-plugins-bad-a962c0f40c1bf71b44a67f898a35122f158b6b25.tar.gz
gst-plugins-bad-a962c0f40c1bf71b44a67f898a35122f158b6b25.tar.bz2
gst-plugins-bad-a962c0f40c1bf71b44a67f898a35122f158b6b25.zip
Add buffer length checks to every typefinding function
Original commit message from CVS: Add buffer length checks to every typefinding function
Diffstat (limited to 'gst/festival/gstfestival.c')
-rw-r--r--gst/festival/gstfestival.c6
1 files changed, 5 insertions, 1 deletions
diff --git a/gst/festival/gstfestival.c b/gst/festival/gstfestival.c
index 7f40e3b0..87416184 100644
--- a/gst/festival/gstfestival.c
+++ b/gst/festival/gstfestival.c
@@ -203,8 +203,12 @@ text_type_find (GstBuffer *buf, gpointer private)
gchar *data = GST_BUFFER_DATA (buf);
gint i;
+ /* 20 is arbitrary. 4 is definitely too small. */
+ if (GST_BUFFER_SIZE (buf) < 20)
+ return NULL;
+
for (i=0; i<GST_BUFFER_SIZE (buf); i++) {
- if (!isprint(*(data+i)))
+ if (!isprint(data[i]) && data[i]!='\n')
return NULL;
}