summaryrefslogtreecommitdiffstats
path: root/gst/mxf
diff options
context:
space:
mode:
authorSebastian Dröge <sebastian.droege@collabora.co.uk>2009-02-08 21:12:21 +0100
committerSebastian Dröge <sebastian.droege@collabora.co.uk>2009-02-08 21:12:21 +0100
commitc33678dab3f2b926675ef8b6eca3198c3c20ecdd (patch)
tree70ea3670e10613643bab47a2875f3dc221261299 /gst/mxf
parent658066d0856d1f26ba083cbae493dd3a0c411a45 (diff)
downloadgst-plugins-bad-c33678dab3f2b926675ef8b6eca3198c3c20ecdd.tar.gz
gst-plugins-bad-c33678dab3f2b926675ef8b6eca3198c3c20ecdd.tar.bz2
gst-plugins-bad-c33678dab3f2b926675ef8b6eca3198c3c20ecdd.zip
mxfdemux: Small cleanup and an additional check
Update TODO list, reduce size of a stack allocated string and don't allow essence tracks with an invalid edit rate
Diffstat (limited to 'gst/mxf')
-rw-r--r--gst/mxf/mxfdemux.c8
1 files changed, 6 insertions, 2 deletions
diff --git a/gst/mxf/mxfdemux.c b/gst/mxf/mxfdemux.c
index 1316c83d..e89e47f5 100644
--- a/gst/mxf/mxfdemux.c
+++ b/gst/mxf/mxfdemux.c
@@ -48,7 +48,6 @@
* - Correctly handle the different rectangles and aspect-ratio for video
* - Add support for non-standard MXF used by Avid (bug #561922).
* - Fix frame layout stuff, i.e. interlaced/progressive
- * - Extend essence element handlers to set DELTA_UNIT flag.
* - In pull mode first find the first buffer for every pad before pushing
* to prevent jumpy playback in the beginning due to resynchronization.
*
@@ -717,6 +716,11 @@ gst_mxf_demux_update_essence_tracks (GstMXFDemux * demux)
if ((track->parent.type & 0xf0) != 0x30)
continue;
+ if (track->edit_rate.n <= 0 || track->edit_rate.d <= 0) {
+ GST_WARNING_OBJECT (demux, "Invalid edit rate");
+ continue;
+ }
+
if (demux->essence_tracks) {
for (k = 0; k < demux->essence_tracks->len; k++) {
GstMXFDemuxEssenceTrack *tmp =
@@ -784,7 +788,7 @@ gst_mxf_demux_update_essence_tracks (GstMXFDemux * demux)
etrack->handler = mxf_essence_element_handler_find (track);
if (!etrack->handler) {
- gchar essence_container[96];
+ gchar essence_container[48];
gchar *name;
GST_WARNING_OBJECT (demux,